[Scummvm-devel] Moving and merging image-related code

Filippos Karapetis bluegr at gmail.com
Wed Feb 2 19:04:26 CET 2011


>
> > iff.* - ILBM decoder (LBM images)
> > imagedec.* - BMP decoder
> The BMP decoder is quite limited in what it can do. One could also
> merge in the one from Mohawk which has 8bpp support.


Sounds good

> png.*
> As I expressed on IRC, I disagreed with having our own PNG decoder and
> I would much rather see libpng used. The dependency on libpng is not
> something that would be ridiculous to depend on and we will most
> likely never equal the speed of libpng.


Why? We don't need all of the functionality of libpng, and it's not like we
absolutely
need top speed when loading an image. We have our own code for all the other
image formats, why is it so wrong in having our own code for PNG as well?
One
less dependency is a good thing in my eyes, especially if it allows us to
port the
game in other platforms and not worry about libpng availability there. So, I
personally
don't understand why libpng is better for our needs.


> > Also, drascula, hugo, queen and tucker all have PCX loading code, so
> perhaps
> > this should be
> > merged to a PCX class together with the other image decoders...
> Yes, I noticed that too. Queen also provides another LBM
> implementation that should probably be switched over to the
> aforementioned ILBM decoder.
>

Great, sounds like a good plan! Less duplicate code :)

Regards
Filippos



-- 
"Experience is the name every one gives to their mistakes" - Oscar Wilde
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20110202/34907678/attachment.html>


More information about the Scummvm-devel mailing list