[Scummvm-devel] Release 1.3.0 status - 2011-05-16

[Filippos Karapetis]

A general question: why don't you join github, so that all of these
changes can be merged
into our code tree? That way, this port will be like all of the
others, and we can have its source
code in our code tree, like with everything else (and like GPL
specifically requests)/

I've just reviewed the patch we got in the tree (/backends/platform/maemo).

Here are some observations/questions. Note that these are against the
patch we got against 1.1.0, so things might have changed. Your work is
greatly appreciated, though there are some things which strike me as
odd:

- What is wrong with the ScummVM icon, so that there is a specific
hack to replace it (in postinit).
If this is to get the icon to show on the window, you could override
setupIcon() instead (check how it's done for the Windows backend in
/backends/platform/sdl/win32/win32.cpp)
- Is there a reason why this port uses an additional external include
for building? (/usr/share/quilt/quilt.make)
- Why are you changing the paths inside configure?
- What error are you getting with kyra/screen.cpp? Can you use a newer
GCC version?
- In general, I see you put in a special handling for the F4 key in
all of the engines... why? We got a menu which pops up with
Control-F5, so overriding that seems a bit more generic than hacking
an F4 key into all of the engines. Plus, some engine might be using
F4, whereas no engine is using Control-F5.
- I see you did the same with the Up, Down, Enter and F8 keys... again
shouldn't these be remapped in the backend, instead of all of the
engines?
- You did some key remapping in /backends/platform/sdl/events.cpp, so
why are some keys remapped in the engine level and some in the backend
level?
- Why is SDL_syswm.h needed? Any specific functionality you need from
it? Could it be the window name? So that means that ScummVM is running
as a window in this platform? If this is the case, you could override
setWindowCaption() instead (e.g. check /platform/sdl/sdl.cpp).
- Why is the SCUMM restart dialog disabled?

Regards
Filippos

On Wed, Jun 29, 2011 at 11:13 AM, Filippos Karapetis <bluegr at gmail.com> wrote:
>>> If this is indeed the situation
>>
>> No it is not.
>
> Um, excuse me, I understand your anger, but the only source code we
> got for this port is in form of a patch against 1.1.0 in
> /backends/platform/maemo. And the situation is that we need your
> source code changes in the tree. Giving a link to a tar.gz is with
> your changes is not, I'm afraid, the proper way to do this.
>
> It seems that we could automate its build process with buildbot too,
> right? What kind of toolchain is required for this port?
>
>> Reading list archives or http://wiki.scummvm.org/index.php/Maemo would be
>> better than all this guesswork and accusations. Also CCing me would be nice
>> too, it is really not hard to figure out who are 'the people who build
>> this'.
>
> You are supposed to be subscribed to scummvm-devel, so why should you be
> specifically CCed here?
>
> Regards
> Filippos
>
> --
> "Experience is the name every one gives to their mistakes" - Oscar Wilde
>



-- 
"Experience is the name every one gives to their mistakes" - Oscar Wilde