[Scummvm-devel] Release 1.3.0 status - 2011-05-16

[Frantisek Dufka]

On 29.6.2011 11:01, Filippos Karapetis wrote:
> A general question: why don't you join github, so that all of these
> changes can be merged
> into our code tree?

Lack of time. I'd like to. Already registered to github but need to 
learn git more. That's one reason why I missed 1.3.0 deadline - 
switching from svn to git way of doing stuff.

> That way, this port will be like all of the
> others

Still learning but I guess with git I can maintain my own scummvm 
branch/fork more visibly and somehow merge stuff or generate the patch 
more easily.

> I've just reviewed the patch we got in the tree (/backends/platform/maemo).

latest is
https://github.com/scummvm/scummvm/tree/v1.2.1/backends/platform/maemo

>
> - What is wrong with the ScummVM icon, so that there is a specific
> hack to replace it (in postinit).

Maemo OS 2006 for 770 needs low resolution xpm icon, OS2007 and up needs 
high resolution png but the low resolution one overrrides the high 
resolution one and looks ugly when present. So for OS > 2006 I need to 
remove the xpm one at package install time, see
https://github.com/scummvm/scummvm/blob/v1.2.1/backends/platform/maemo/scummvm-1.2-maemo.patch#L325

> If this is to get the icon to show on the window

Icon is for system application 'start' menu.

> - Is there a reason why this port uses an additional external include
> for building? (/usr/share/quilt/quilt.make)

This is for quilt tool, it is one of build dependencies. Quilt was used 
for applying some specific patches at build time when uploading same 
source archive to Maemo autobuilder for different targets (OS2008 vs 
Maemo 5). It didn't solve everything so right now all patches managed by 
quilt are integrated and quilt currently does nothing and the dependency 
can be removed. It is harmless though.

> - Why are you changing the paths inside configure?

Explained few times, last time to Max earlier in this thread. See
Subject: Re: [Scummvm-devel] Release 1.3.0 status -- 2010-04-24
Date: Tue, 24 May 2011 14:20:49 +0200
CC: ScummVM devel <scummvm-devel at lists.sourceforge.net>

There is more about Maemo port status in that thread so might be worth 
reading. Max had some very good suggestions so there is no need to 
reinvent the wheel.

In general when I was more active in Maemo and ScummVM there was no 
other practical way to do Maemo port than patching sdl backend and 
engines directly. Now the SDL backend is modularized and there is 
keymapper in some form so now there are better ways. But my spare coding 
time became recently very limited and also Maemo is less and less 
relevant (some would say dead) so I am no longer up to speed with recent 
scummvm changes.

> - What error are you getting with kyra/screen.cpp? Can you use a newer
> GCC version?

https://github.com/scummvm/scummvm/blob/v1.2.1/backends/platform/maemo/scummvm-1.2-maemo.patch#L449
internal compiler error with -O2 or -Os, no newer compiler for 770

> - In general, I see you put in a special handling for the F4 key in
> all of the engines... why? We got a menu which pops up with
> Control-F5, so overriding that seems a bit more generic than hacking
> an F4 key into all of the engines. Plus, some engine might be using
> F4, whereas no engine is using Control-F5.

Nokia 770 and N800 has no keyboard. Only directional keypad and few keys 
mapped to F4-F8 and F5 is eaten by system (f5 = home key = device goes 
to home screen or pops up task manager menu, no way to block it) So I 
need to map f5 out and map most stuff to f4,f6,f7,f8 and keypad, see
http://wiki.scummvm.org/index.php/Maemo#Device_specific_keybindings

> - You did some key remapping in /backends/platform/sdl/events.cpp, so
> why are some keys remapped in the engine level and some in the backend
> level?

The mapping in events.cpp is newer way and I could perhaps rewrite some 
of older engine patches to this way (and I already did some over time) 
but not all. Some of them are engine state specific (i.e. maemo mapping 
is changed in engine only for some code paths, not all) so not 
everything can live in events.cpp

> - Why is SDL_syswm.h needed?

Needed for some Maemo5 (N900) hacks/workarounds, see 
https://github.com/scummvm/scummvm/blob/v1.2.1/backends/platform/maemo/scummvm-1.2-maemo.patch#L843

> - Why is the SCUMM restart dialog disabled?

In general this is because for devices with no keyboard and limited keys 
there is either no way to invoke it or it interferes with available key 
needed for other action.

In this case it is F8 which maemo uses for 'zoom -' key and is mapped to 
something else.


Regards,
Frantisek

BTW, there is no need to forward all emails to me, I am subscribed to 
scummvm-devel, it was only good to CC: me first time when replying to a 
month old thread.