[Scummvm-devel] Audio::MidiPlayer

[Robert Špalek]

On Mon, Mar 28, 2011 at 9:15 AM, Max Horn <max at quendi.de> wrote:

> * A few engines (agi, draci, hugo) handle newly created MidiChannel's
> differently, taking extra care to call the volume() method of the new
> channel, thus enforcing the aforementioned default channel volume. Is this
> really necessary? If yes, then should we introduced it for other engines,
> too? Otherwise, explain / document the difference.
>
> I don't remember my reasoning when I was implementing MIDI in draci, and I
never understood almost anything about what I was doing, just copying the
code from elsewhere and patching it (in way too many iterations) until
everything worked, but I remember that things simply didn't work without
this work-around.  not sure now what kind of sound artifact had been
happening without that work-around.

I will test your new implementation and search the old SVN logs for the
particular commit, and reply to this thread with the outcome.

thank you very much for the refactoring!  I had wishes something like this
existed before :-)
-- 
Robert Špalek <rspalek at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20110328/7af46e1b/attachment.html>