[Scummvm-devel] ATTN: configure changes

D G Turner d.g.turner at ntlworld.com
Sat Nov 26 13:23:04 CET 2011


On 11/25/11 23:05, Tarek Soliman wrote:
> On Fri, Nov 25, 2011 at 01:58:16PM +0000, Willem Jan Palenstijn wrote:
>> On Fri, Nov 25, 2011 at 01:41:55PM +0000, Thierry Crozat wrote:
>>> Another remark, but this is a nitpick and maybe not worth changing,
>>> since the --enable-engine expect a list of engines shouldn't it be
>>> named --enable-engines (with an 's' at the end)?
>>
>> Maybe... looking back through the IRC logs I originally said --enable-engines
>> too. If we want to change it, the sooner the better... any opinions? 
> 
> It should accept both I think.

I think this is a reasonable suggestion.

Was fairly easy to implement so have committed this as r61a1b49 to master.

We can now have the discussion about which is the "official"
format to be in the help output...
and whether I should limit --enable-engine to a single parameter and
enforce multiple parameters for --enable-engines=...

(This is semi serious irony, and I'm bringing it up before anyone else
 does. I'm leaning towards a permissive syntax here, but if anyone
 can give me an advantage to tightening this up, I am happy to look
 at implementing a stricter parsing.)
-- 
Thanks,
David Turner





More information about the Scummvm-devel mailing list