[Scummvm-devel] Translations and OSystem::logMessage()
fuzzie at users.sourceforge.net
Thu Aug 8 09:28:58 CEST 2013
On Wed, Aug 07, 2013 at 11:34:19PM +0100, Thierry Crozat wrote:
> So that lead me to a question: Should we limit the use of the TranslationManager to messages that are displayed in our GUI?
I don't think "ScummVM needs better character set support" is a good reason
for disabling translations of non-GUI messages. If you really think it's a
bad idea to have translated messages in the log, then OK (I don't really
have an opinion here) but if it's just about the non-ASCII problems then I
think we should really look at fixing that instead.
> In the case of this reportUnknown() though I am wondering if we should not display it both untranslated in logMessage() and translated in a GUI dialog, and since we have OSystem::displayLogFile() and kFeatureDisplayLogFile we could have a button to open the log in that dialog on systems that support it (I would prefer a button to copy to clipboard but that would require adding that to OSystem and at least the SDL backend).
So: one problem with putting a GUI dialog here is that it would cause
problems with 'mass add'. (Another problem is that there's other code
which gives output during detection, e.g. the warning in the pirate
detection and engine-specific detection).
I was vaguely wondering if we could solve that by temporarily logging
the logMessage results into a buffer, and then displaying that in the
GUI when the detection is done, but that doesn't work very well if you
de-translate the messages I guess. :-P Probably it's not a very good
idea anyway, but I'm not sure how to deal with it otherwise.
More information about the Scummvm-devel