[Scummvm-devel] ScummVM 1.7.0 Release. Final date for ports and translations

[D G Turner]

Fixed in f02fa14f00eb2f67b6ae9607771b47d801a3e968 on branch-1-7
and 6731eb21e3e4c1fa2470ed03a3547d45b3dff6e3 in master.

Have avoided the need for vdebug usage, by removing the wrapping
function which just calls debug() anyway, which can deal with
variadic arguments.

On 10/07/14 21:41, Willem Jan Palenstijn wrote:
> On Thu, Jul 10, 2014 at 10:21:03PM +0200, Marcus Comstedt wrote:
>>
>> Eugene Sandulenko <sev at scummvm.org> writes:
>>
>>> This is final heads up for ports and translations. Taggins will happen
>>> tomorrow in about 24 hours from now.
>>
>> Hm, doesn't this look bad:
>>
>> ../audio/softsynth/mt32/Synth.cpp: In member function `virtual void MT32Emu::ReportHandler::printDebug(const char*, va_list)':
>> ../audio/softsynth/mt32/Synth.cpp:103: warning: cannot pass objects of non-POD type `struct va_list' through `...'; call will abort at runtime
>>
>> It looks like commit 3d12f147 changed a call to vprintf (which takes a
>> va_list) into a call to debug (which is a varargs function, taking
>> ...).  I guess it needs to call some form of "vdebug" instead?
> 
> 
> Thanks for catching that. I'm not sure I'm happy with a Munt upgrade in a
> release branch.
> 
> It seems a bit risky, and release branches are feature-frozen.
> 
> -Willem Jan