[Scummvm-cvs-logs] CVS: scummvm/scumm actor.cpp,1.157,1.158

Max Horn fingolfin at users.sourceforge.net
Mon Aug 25 15:37:39 CEST 2003


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv2529

Modified Files:
	actor.cpp 
Log Message:
fix actor position in V1 games (by eyeballing the original in dosbox); still seems to be off 1 pixel vertically (?), and actors still leave dirt

Index: actor.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/actor.cpp,v
retrieving revision 1.157
retrieving revision 1.158
diff -u -d -r1.157 -r1.158
--- actor.cpp	25 Aug 2003 20:05:02 -0000	1.157
+++ actor.cpp	25 Aug 2003 20:57:36 -0000	1.158
@@ -958,13 +958,16 @@
 	bcr->_actorX = x - _vm->virtscr[0].xstart;
 	bcr->_actorY = y - elevation;
 
-	if (_vm->_version == 2) {
-		// FIXME: We have to adjust the x position by one strip (8 pixels) in V2 games
-		// However, it is not quite clear to me why. And to fully match the original,
-		// it seems we have to offset by 2 strips when facing left (270 degree).
+	if (_vm->_version <= 2) {
+		// HACK: We have to adjust the x position by one strip (8 pixels) in
+		// V2 games. However, it is not quite clear to me why. And to fully
+		// match the original, it seems we have to offset by 2 strips if the
+		// actor is facing left (270 degree).
+		// V1 games are once again slightly different, here we only have
+		// to adjust the 270 degree case...
 		if (facing == 270)
 			bcr->_actorX += 16;
-		else
+		else if (_vm->_version == 2)
 			bcr->_actorX += 8;
 	}
 





More information about the Scummvm-git-logs mailing list