[Scummvm-cvs-logs] SF.net SVN: scummvm: [25666] scummvm/trunk

[fingolfin at users.sourceforge.net]

Revision: 25666
          http://scummvm.svn.sourceforge.net/scummvm/?rev=25666&view=rev
Author:   fingolfin
Date:     2007-02-17 14:11:00 -0800 (Sat, 17 Feb 2007)

Log Message:
-----------
Get rid of Common::SaveFile

Modified Paths:
--------------
    scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.cpp
    scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.h
    scummvm/trunk/backends/platform/ds/arm9/source/ramsave.cpp
    scummvm/trunk/backends/platform/ds/arm9/source/ramsave.h
    scummvm/trunk/common/savefile.h

Modified: scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.cpp
===================================================================
--- scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.cpp	2007-02-17 21:19:55 UTC (rev 25665)
+++ scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.cpp	2007-02-17 22:11:00 UTC (rev 25666)
@@ -139,7 +139,7 @@
 
 }
 
-Common::SaveFile* GBAMPSaveFileManager::openSavefile(char const* name, bool saveOrLoad) {
+GBAMPSaveFile* GBAMPSaveFileManager::openSavefile(char const* name, bool saveOrLoad) {
 	char fileSpec[128];
 	
 	strcpy(fileSpec, getSavePath());

Modified: scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.h
===================================================================
--- scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.h	2007-02-17 21:19:55 UTC (rev 25665)
+++ scummvm/trunk/backends/platform/ds/arm9/source/gbampsave.h	2007-02-17 22:11:00 UTC (rev 25666)
@@ -26,7 +26,7 @@
 
 #define SAVE_BUFFER_SIZE 100000
 
-class GBAMPSaveFile : public Common::SaveFile {
+class GBAMPSaveFile : public InSaveFile, public OutSaveFile {
 	FILE* handle;
 	char buffer[SAVE_BUFFER_SIZE];
 	int bufferPos;
@@ -64,7 +64,7 @@
 	
 //	static GBAMPSaveFileManager* instance() { return instancePtr; }
 
-	Common::SaveFile *openSavefile(const char *filename, bool saveOrLoad);
+	GBAMPSaveFile *openSavefile(const char *filename, bool saveOrLoad);
 	
 	virtual Common::OutSaveFile* openForSaving(const char* filename) { return openSavefile(filename, true); }
 	virtual Common::InSaveFile* openForLoading(const char* filename) { return openSavefile(filename, false); }
@@ -74,9 +74,6 @@
 	
 	void deleteFile(char* name);
 	void listFiles();
-	
-protected:
-	Common::SaveFile *makeSaveFile(const char *filename, bool saveOrLoad);
 };
 
 

Modified: scummvm/trunk/backends/platform/ds/arm9/source/ramsave.cpp
===================================================================
--- scummvm/trunk/backends/platform/ds/arm9/source/ramsave.cpp	2007-02-17 21:19:55 UTC (rev 25665)
+++ scummvm/trunk/backends/platform/ds/arm9/source/ramsave.cpp	2007-02-17 22:11:00 UTC (rev 25666)
@@ -346,7 +346,7 @@
 
 DSSaveFileManager* DSSaveFileManager::instancePtr = NULL;
 
-Common::SaveFile *DSSaveFileManager::openSavefile(const char* filename, bool saveOrLoad) {
+DSSaveFile *DSSaveFileManager::openSavefile(const char* filename, bool saveOrLoad) {
 	for (int r = 0; r < 8; r++) {
 		if (gbaSave[r].isValid() && (gbaSave[r].matches((char *) filename))) {
 //			consolePrintf("Matched save %d (%d)\n", r, gbaSave[r].getSize());
@@ -398,7 +398,7 @@
 	
 }
 
-Common::SaveFile *DSSaveFileManager::makeSaveFile(const char *filename, bool saveOrLoad) {
+DSSaveFile *DSSaveFileManager::makeSaveFile(const char *filename, bool saveOrLoad) {
 	
 	// Find a free save slot
 	int r = 0;

Modified: scummvm/trunk/backends/platform/ds/arm9/source/ramsave.h
===================================================================
--- scummvm/trunk/backends/platform/ds/arm9/source/ramsave.h	2007-02-17 21:19:55 UTC (rev 25665)
+++ scummvm/trunk/backends/platform/ds/arm9/source/ramsave.h	2007-02-17 22:11:00 UTC (rev 25666)
@@ -28,7 +28,7 @@
 
 #define DS_MAX_SAVE_SIZE 150000
 
-class DSSaveFile : public Common::SaveFile {
+class DSSaveFile : public InSaveFile, public OutSaveFile {
 	int address;
 	int ptr;
 	bool ownsData;
@@ -116,7 +116,7 @@
 	
 	static DSSaveFileManager* instance() { return instancePtr; }
 
-	Common::SaveFile *openSavefile(const char *filename, bool saveOrLoad);
+	DSSaveFile *openSavefile(const char *filename, bool saveOrLoad);
 	
 	virtual Common::OutSaveFile* openForSaving(const char* filename) { return openSavefile(filename, true); }
 	virtual Common::InSaveFile* openForLoading(const char* filename) { return openSavefile(filename, false); }
@@ -140,7 +140,7 @@
 	static void setExtraData(int data);
 
 protected:
-	Common::SaveFile *makeSaveFile(const char *filename, bool saveOrLoad);
+	DSSaveFile *makeSaveFile(const char *filename, bool saveOrLoad);
 };
 
 #endif

Modified: scummvm/trunk/common/savefile.h
===================================================================
--- scummvm/trunk/common/savefile.h	2007-02-17 21:19:55 UTC (rev 25665)
+++ scummvm/trunk/common/savefile.h	2007-02-17 22:11:00 UTC (rev 25666)
@@ -56,11 +56,20 @@
 	}
 };
 
+
 /**
- * Convenience intermediate class, to be removed.
+ * The SaveFileManager is serving as a factor for InSaveFile
+ * and OutSaveFile objects.
+ *
+ * Engines and other code should use SaveFiles whenever they need to
+ * store data which they need to be able to retrieve later on --
+ * i.e. typically save states, but also configuration files and similar
+ * things.
+ *
+ * While not declared as a singleton,
+ * it is effectively used as such, with OSystem::getSavefileManager
+ * returning the single SaveFileManager instances to be used.
  */
-class SaveFile : public InSaveFile, public OutSaveFile {};
-
 class SaveFileManager {
 
 public:


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.