[Scummvm-cvs-logs] SF.net SVN: scummvm:[43880] scummvm/trunk/backends/events/default/ default-events.cpp

[fingolfin at users.sourceforge.net]

Revision: 43880
          http://scummvm.svn.sourceforge.net/scummvm/?rev=43880&view=rev
Author:   fingolfin
Date:     2009-09-01 13:02:24 +0000 (Tue, 01 Sep 2009)

Log Message:
-----------
Clarified the backspace key workaround: This is not a Mac OS X issue (as the comment used to imply) but rather an issue in some game engines.

Modified Paths:
--------------
    scummvm/trunk/backends/events/default/default-events.cpp

Modified: scummvm/trunk/backends/events/default/default-events.cpp
===================================================================
--- scummvm/trunk/backends/events/default/default-events.cpp	2009-09-01 13:01:59 UTC (rev 43879)
+++ scummvm/trunk/backends/events/default/default-events.cpp	2009-09-01 13:02:24 UTC (rev 43880)
@@ -163,9 +163,13 @@
 			}
 #endif
 			else if (event.kbd.keycode == Common::KEYCODE_BACKSPACE) {
-				// WORKAROUND: On Mac OS X, the ascii value for backspace
-				// has to be set to the backspace keycode in order to work
-				// properly.
+				// WORKAROUND: Some engines incorrectly attempt to use the
+				// ascii value instead of the keycode to detect the backspace
+				// key (a non-portable behavior). This fails at least on
+				// Mac OS X, possibly also on other systems.
+				// As a workaround, we force the ascii value for backspace
+				// key pressed. A better fix would be for engines to stop
+				// making invalid assumptions about ascii values.
 				event.kbd.ascii = Common::KEYCODE_BACKSPACE;
 			}
 			break;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.