[Scummvm-cvs-logs] SF.net SVN: scummvm:[51456] scummvm/trunk/engines/sci/engine

[thebluegr at users.sourceforge.net]

Revision: 51456
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51456&view=rev
Author:   thebluegr
Date:     2010-07-29 07:58:48 +0000 (Thu, 29 Jul 2010)

Log Message:
-----------
SCI: Silenced warning when exiting in LSL6 (bug report #3035533), and commented out a related unused variable in kSetQuitStr

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/kstring.cpp
    scummvm/trunk/engines/sci/engine/message.cpp

Modified: scummvm/trunk/engines/sci/engine/kstring.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/kstring.cpp	2010-07-29 07:17:42 UTC (rev 51455)
+++ scummvm/trunk/engines/sci/engine/kstring.cpp	2010-07-29 07:58:48 UTC (rev 51456)
@@ -566,7 +566,7 @@
 }
 
 reg_t kSetQuitStr(EngineState *s, int argc, reg_t *argv) {
-	Common::String quitStr = s->_segMan->getString(argv[0]);
+	//Common::String quitStr = s->_segMan->getString(argv[0]);
 	//debug("Setting quit string to '%s'", quitStr.c_str());
 	return s->r_acc;
 }

Modified: scummvm/trunk/engines/sci/engine/message.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/message.cpp	2010-07-29 07:17:42 UTC (rev 51455)
+++ scummvm/trunk/engines/sci/engine/message.cpp	2010-07-29 07:58:48 UTC (rev 51456)
@@ -380,7 +380,15 @@
 		if ((unsigned)buffer_r.maxSize >= str.size() + 1) {
 			_segMan->strcpy(buf, str.c_str());
 		} else {
-			warning("Message: buffer %04x:%04x invalid or too small to hold the following text of %i bytes: '%s'", PRINT_REG(buf), str.size() + 1, str.c_str());
+			// LSL6 sets an exit text here, but the buffer size allocated
+			// is too small. Don't display a warning in this case, as we
+			// don't use the exit text anyway - bug report #3035533
+			const char *foo = str.c_str();
+			if (g_sci->getGameId() == GID_LSL6 && str.hasPrefix("\r\n(c) 1993 Sierra On-Line, Inc")) {
+				// LSL6 buggy exit text, don't show warning
+			} else {
+				warning("Message: buffer %04x:%04x invalid or too small to hold the following text of %i bytes: '%s'", PRINT_REG(buf), str.size() + 1, str.c_str());
+			}
 
 			// Set buffer to empty string if possible
 			if (buffer_r.maxSize > 0)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.