[Scummvm-cvs-logs] SF.net SVN: scummvm:[50516] scummvm/trunk/engines/sci/engine/klists.cpp

[thebluegr at users.sourceforge.net]

Revision: 50516
          http://scummvm.svn.sourceforge.net/scummvm/?rev=50516&view=rev
Author:   thebluegr
Date:     2010-06-30 07:28:30 +0000 (Wed, 30 Jun 2010)

Log Message:
-----------
Also erase the value of the list node itself when deleting it inside kDeleteKey, as it might be referenced again before the GC is invoked

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/klists.cpp

Modified: scummvm/trunk/engines/sci/engine/klists.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/klists.cpp	2010-06-30 07:18:43 UTC (rev 50515)
+++ scummvm/trunk/engines/sci/engine/klists.cpp	2010-06-30 07:28:30 UTC (rev 50516)
@@ -346,9 +346,11 @@
 	if (!n->succ.isNull())
 		s->_segMan->lookupNode(n->succ)->pred = n->pred;
 
-	// Erase references to the predecessor and successor nodes
+	// Erase the node itself, as the game might reference it
+	// again before the GC is invoked
 	n->pred = NULL_REG;
 	n->succ = NULL_REG;
+	n->value = NULL_REG;
 
 	return make_reg(0, 1); // Signal success
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.