[Scummvm-cvs-logs] scummvm master -> b16d6e8bb26e6c411e76c18afab104d535c57387

wjp wjp at usecode.org
Fri Jun 3 14:19:23 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b16d6e8bb2 TESTBED: Get rid of static local variable


Commit: b16d6e8bb26e6c411e76c18afab104d535c57387
    https://github.com/scummvm/scummvm/commit/b16d6e8bb26e6c411e76c18afab104d535c57387
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2011-06-03T05:15:39-07:00

Commit Message:
TESTBED: Get rid of static local variable

It's not only against our coding guidelines, but also breaks running the
mutex test multiple times. It may or may not also be responsible for a
MSVC9 build failure reported on IRC.

Changed paths:
    engines/testbed/misc.cpp



diff --git a/engines/testbed/misc.cpp b/engines/testbed/misc.cpp
index 35b3c6b..70a0d88 100644
--- a/engines/testbed/misc.cpp
+++ b/engines/testbed/misc.cpp
@@ -132,7 +132,7 @@ TestExitStatus MiscTests::testMutexes() {
 		Testsuite::writeOnScreen("Installing mutex", Common::Point(0, 100));
 	}
 
-	static SharedVars sv = {1, 1, true, g_system->createMutex()};
+	SharedVars sv = {1, 1, true, g_system->createMutex()};
 
 	if (g_system->getTimerManager()->installTimerProc(criticalSection, 100000, &sv)) {
 		g_system->delayMillis(150);






More information about the Scummvm-git-logs mailing list