[Scummvm-cvs-logs] scummvm master -> 87070cbdc8f8c08ca10b16ce3a3ded70c5f52e2b

wjp wjp at usecode.org
Fri Jun 3 14:45:51 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
87070cbdc8 TESTBED: Remove another static and a confusing comment


Commit: 87070cbdc8f8c08ca10b16ce3a3ded70c5f52e2b
    https://github.com/scummvm/scummvm/commit/87070cbdc8f8c08ca10b16ce3a3ded70c5f52e2b
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2011-06-03T05:42:25-07:00

Commit Message:
TESTBED: Remove another static and a confusing comment

Changed paths:
    engines/testbed/misc.cpp



diff --git a/engines/testbed/misc.cpp b/engines/testbed/misc.cpp
index 70a0d88..642e0b8 100644
--- a/engines/testbed/misc.cpp
+++ b/engines/testbed/misc.cpp
@@ -30,7 +30,6 @@ Common::String MiscTests::getHumanReadableFormat(TimeDate &td) {
 
 void MiscTests::timerCallback(void *arg) {
 	// Increment arg which actually points to an int
-	// arg must point to a static data, threads otherwise have their own stack
 	int &valToModify = *((int *) arg);
 	valToModify = 999; // some arbitrary value
 }
@@ -110,7 +109,7 @@ TestExitStatus MiscTests::testDateTime() {
 }
 
 TestExitStatus MiscTests::testTimers() {
-	static int valToModify = 0;
+	int valToModify = 0;
 	if (g_system->getTimerManager()->installTimerProc(timerCallback, 100000, &valToModify)) {
 		g_system->delayMillis(150);
 		g_system->getTimerManager()->removeTimerProc(timerCallback);






More information about the Scummvm-git-logs mailing list