[Scummvm-git-logs] scummvm master -> b513242292b5b993b58f5059c7bedb64ca122d91

dreammaster paulfgilbert at gmail.com
Sat Aug 29 22:06:09 UTC 2020


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b513242292 MADS: Avoid potential crash for reading beyond end of sound data


Commit: b513242292b5b993b58f5059c7bedb64ca122d91
    https://github.com/scummvm/scummvm/commit/b513242292b5b993b58f5059c7bedb64ca122d91
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2020-08-29T15:06:00-07:00

Commit Message:
MADS: Avoid potential crash for reading beyond end of sound data

Changed paths:
    engines/mads/nebular/sound_nebular.cpp


diff --git a/engines/mads/nebular/sound_nebular.cpp b/engines/mads/nebular/sound_nebular.cpp
index 15dd44a4af..f698209271 100644
--- a/engines/mads/nebular/sound_nebular.cpp
+++ b/engines/mads/nebular/sound_nebular.cpp
@@ -466,6 +466,7 @@ void ASound::pollActiveChannel() {
 				}
 				if (pSrc > chan->_ptrEnd) {
 					warning("Read beyond end of loaded sound data");
+					return;
 				}
 
 				if (!(*pSrc & 0x80) || (*pSrc <= 0xF0)) {




More information about the Scummvm-git-logs mailing list