[Scummvm-git-logs] scummvm master -> 82d4357c2e5ec656c4a98bddf0cc0cd576c2d051

[dreammaster]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
82d4357c2e GLK: ZCODE: Turn off autosaves for ZCode games


Commit: 82d4357c2e5ec656c4a98bddf0cc0cd576c2d051
    https://github.com/scummvm/scummvm/commit/82d4357c2e5ec656c4a98bddf0cc0cd576c2d051
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2020-09-05T19:57:29-07:00

Commit Message:
GLK: ZCODE: Turn off autosaves for ZCode games

ZMachine saves also includes the current execution
stack. So I'm honestly not sure how to create an
autosave in the background that has a valid stack
than can be properly restored. With an imminent
release, it's better to disable autosaves for now

Changed paths:
    engines/glk/zcode/zcode.cpp
    engines/glk/zcode/zcode.h


diff --git a/engines/glk/zcode/zcode.cpp b/engines/glk/zcode/zcode.cpp
index 862b20b693..179a4b99f0 100644
--- a/engines/glk/zcode/zcode.cpp
+++ b/engines/glk/zcode/zcode.cpp
@@ -139,6 +139,7 @@ Common::Error ZCode::saveGameState(int slot, const Common::String &desc, bool is
 
 	Quetzal q(story_fp);
 	bool success = q.save(*file, this, desc);
+	file->close();
 
 	if (!success)
 		print_string_uni(_("Error writing save file\n").c_str());
diff --git a/engines/glk/zcode/zcode.h b/engines/glk/zcode/zcode.h
index b3f48e7ac5..d18cac64a6 100644
--- a/engines/glk/zcode/zcode.h
+++ b/engines/glk/zcode/zcode.h
@@ -71,6 +71,17 @@ public:
 	 */
 	void runGame() override;
 
+	/**
+	 * Indicates whether an autosave can currently be saved.
+	 */
+	virtual bool canSaveAutosaveCurrently() {
+		/* ZCode saves also include the execution stack.
+		 * So I don't know how to do autosaves in the background
+		 * without ending up with an invalid stack state
+		 */
+		return false;
+	}
+
 	/**
 	 * Load a savegame from a given slot
 	 */