[Scummvm-git-logs] scummvm master -> 38910552144de93da145e91cf16b5461a80d884d

sev- sev at scummvm.org
Fri Apr 9 15:46:41 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3891055214 GUI: Fix caching of Edit Game dialog layout


Commit: 38910552144de93da145e91cf16b5461a80d884d
    https://github.com/scummvm/scummvm/commit/38910552144de93da145e91cf16b5461a80d884d
Author: DivyamAhuja (39771050+DivyamAhuja at users.noreply.github.com)
Date: 2021-04-09T17:46:38+02:00

Commit Message:
GUI: Fix caching of Edit Game dialog layout

Changed paths:
    gui/widget.cpp


diff --git a/gui/widget.cpp b/gui/widget.cpp
index a682c2eb32..f2776f5443 100644
--- a/gui/widget.cpp
+++ b/gui/widget.cpp
@@ -954,9 +954,9 @@ void OptionsContainerWidget::reflowLayout() {
 	Widget::reflowLayout();
 
 	if (!_dialogLayout.empty()) {
-		if (!g_gui.xmlEval()->hasDialog(_dialogLayout)) {
-			defineLayout(*g_gui.xmlEval(), _dialogLayout, _name);
-		}
+		// Since different engines have different number of options,
+		// we have to create it every time.
+		defineLayout(*g_gui.xmlEval(), _dialogLayout, _name);
 
 		if (!_scrollContainer) {
 			g_gui.xmlEval()->reflowDialogLayout(_dialogLayout, _firstWidget);




More information about the Scummvm-git-logs mailing list