[Scummvm-git-logs] scummvm master -> 8c5ef7b490ed40918f1236419e8ab82fd72cf5d5

[sev-]

This automated email contains information about 3 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a42f81af5a ZVISION: Add detection for unsupported Mac version. Bugreport #11755
315048a006 ZVISION: Added detection for unsupported Mac znemesis. Bugreport #11755
8c5ef7b490 KYRA: Added detection entry for incorrectly set up GOG lol. Bugreport #11769


Commit: a42f81af5ac07cdd3b372406ffd807df737f746f
    https://github.com/scummvm/scummvm/commit/a42f81af5ac07cdd3b372406ffd807df737f746f
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2021-04-22T18:41:15+02:00

Commit Message:
ZVISION: Add detection for unsupported Mac version. Bugreport #11755

Changed paths:
    engines/zvision/detection_tables.h


diff --git a/engines/zvision/detection_tables.h b/engines/zvision/detection_tables.h
index 4d0e3ea577..c2bb0ee7ab 100644
--- a/engines/zvision/detection_tables.h
+++ b/engines/zvision/detection_tables.h
@@ -180,6 +180,24 @@ static const ZVisionGameDescription gameDescriptions[] = {
 		GID_NEMESIS
 	},
 
+	{
+		// Zork Nemesis English Mac version
+		{
+			"znemesis",
+			_s("Missing game code"), // Reason for being unsupported
+			{
+				{ "CSCR.ZFS", 0, "ce26cbb17bfbaa774742b3187262a7c0", 2597635 },
+				{ "ASCR.ZFS", 0, "5ee98db1bf73983eb8148da231342085", 929931 },
+				AD_LISTEND
+			},
+			Common::EN_ANY,
+			Common::kPlatformMacintosh,
+			ADGF_UNSUPPORTED,
+			GUIO4(GAMEOPTION_ORIGINAL_SAVELOAD, GAMEOPTION_DOUBLE_FPS, GAMEOPTION_ENABLE_VENUS, GAMEOPTION_DISABLE_ANIM_WHILE_TURNING)
+		},
+		GID_NEMESIS
+	},
+
 	{
 		// Zork Nemesis English demo version
 		{


Commit: 315048a00669dc11a68a2e21cc1a1022e2e42a88
    https://github.com/scummvm/scummvm/commit/315048a00669dc11a68a2e21cc1a1022e2e42a88
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2021-04-22T18:41:18+02:00

Commit Message:
ZVISION: Added detection for unsupported Mac znemesis. Bugreport #11755

Changed paths:
    engines/zvision/detection_tables.h


diff --git a/engines/zvision/detection_tables.h b/engines/zvision/detection_tables.h
index c2bb0ee7ab..5c0724f2f0 100644
--- a/engines/zvision/detection_tables.h
+++ b/engines/zvision/detection_tables.h
@@ -182,6 +182,9 @@ static const ZVisionGameDescription gameDescriptions[] = {
 
 	{
 		// Zork Nemesis English Mac version
+		// Bugreport #11755
+		// These are proper checksums, but it is not working with AD so far
+		// (see comment at the start of getFileProperties()
 		{
 			"znemesis",
 			_s("Missing game code"), // Reason for being unsupported
@@ -192,6 +195,26 @@ static const ZVisionGameDescription gameDescriptions[] = {
 			},
 			Common::EN_ANY,
 			Common::kPlatformMacintosh,
+			ADGF_UNSUPPORTED | ADGF_MACRESFORK,
+			GUIO4(GAMEOPTION_ORIGINAL_SAVELOAD, GAMEOPTION_DOUBLE_FPS, GAMEOPTION_ENABLE_VENUS, GAMEOPTION_DISABLE_ANIM_WHILE_TURNING)
+		},
+		GID_NEMESIS
+	},
+
+	{
+		// Zork Nemesis English Mac version
+		// These are improper checksums for MacBinary files
+		// Added to avoid further bugreports.
+		{
+			"znemesis",
+			_s("Missing game code"), // Reason for being unsupported
+			{
+				{ "CSCR.ZFS", 0, "afcf3b38c210db13988fe7b22d5b2288", 2597888 },
+				{ "ASCR.ZFS", 0, "75e07b46ef60967c9ea66a19e4916b0f", 930176 },
+				AD_LISTEND
+			},
+			Common::EN_ANY,
+			Common::kPlatformMacintosh,
 			ADGF_UNSUPPORTED,
 			GUIO4(GAMEOPTION_ORIGINAL_SAVELOAD, GAMEOPTION_DOUBLE_FPS, GAMEOPTION_ENABLE_VENUS, GAMEOPTION_DISABLE_ANIM_WHILE_TURNING)
 		},


Commit: 8c5ef7b490ed40918f1236419e8ab82fd72cf5d5
    https://github.com/scummvm/scummvm/commit/8c5ef7b490ed40918f1236419e8ab82fd72cf5d5
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2021-04-22T18:41:18+02:00

Commit Message:
KYRA: Added detection entry for incorrectly set up GOG lol. Bugreport #11769

Changed paths:
    engines/kyra/detection_tables.h


diff --git a/engines/kyra/detection_tables.h b/engines/kyra/detection_tables.h
index 44b9129f96..775b5be80d 100644
--- a/engines/kyra/detection_tables.h
+++ b/engines/kyra/detection_tables.h
@@ -1232,6 +1232,22 @@ const KYRAGameDescription adGameDescs[] = {
 		LOL_CD_FLAGS
 	},
 
+	// Incorrectly added GOG CD version
+	// Based on Bugreport #11769
+	{
+		{
+			"lol",
+			_s("You added the game incorrectly. The game data is in ISO image GAME.DAT."),
+			AD_ENTRY2s("VOC.PAK", "eb398f09ba3321d872b6174a68a987d9", 2276340,
+					   "GAME.DAT", "f6ec0ee628b6b2ea4a1b551e3071d84b", 306751488),
+			Common::EN_ANY,
+			Common::kPlatformDOS,
+			ADGF_WARNING | ADGF_DROPLANGUAGE | ADGF_CD,
+			GUIO5(GUIO_MIDIADLIB, GUIO_MIDIMT32, GUIO_MIDIGM, GUIO_MIDIPCSPK, GUIO_RENDERVGA)
+		},
+		LOL_CD_FLAGS
+	},
+
 	// Russian fan translation. Version 1. 03.01.2011
 	{
 		{