[Scummvm-git-logs] scummvm master -> db9a9ca3be244caa473a9f10c657d4610d6a1824

sev- noreply at scummvm.org
Tue Dec 21 23:44:47 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
db9a9ca3be SCUMM: IMUSE: Fix potential memory override


Commit: db9a9ca3be244caa473a9f10c657d4610d6a1824
    https://github.com/scummvm/scummvm/commit/db9a9ca3be244caa473a9f10c657d4610d6a1824
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2021-12-22T00:44:08+01:00

Commit Message:
SCUMM: IMUSE: Fix potential memory override

Changed paths:
    engines/scumm/imuse_digi/dimuse_triggers.cpp


diff --git a/engines/scumm/imuse_digi/dimuse_triggers.cpp b/engines/scumm/imuse_digi/dimuse_triggers.cpp
index 5723f3ab41..f433cc5617 100644
--- a/engines/scumm/imuse_digi/dimuse_triggers.cpp
+++ b/engines/scumm/imuse_digi/dimuse_triggers.cpp
@@ -167,7 +167,7 @@ void IMuseDigiTriggersHandler::processTriggers(int soundId, char *marker) {
 		return;
 	}
 
-	Common::strlcpy(_textBuffer, marker, strlen(marker));
+	Common::strlcpy(_textBuffer, marker, sizeof(textBuffer));
 	_midProcessing++;
 	for (int l = 0; l < DIMUSE_MAX_TRIGGERS; l++) {
 		if (!_trigs[l].sound || _trigs[l].sound != soundId || (_trigs[l].text[0] && strcmp(_textBuffer, _trigs[l].text))) {




More information about the Scummvm-git-logs mailing list