[Scummvm-git-logs] scummvm master -> 308a259e55406134a1906f2ffa9591247fe2a594

bluegr bluegr at gmail.com
Mon May 31 06:24:53 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
308a259e55 TRECISION: Fix some issues found by Coverity


Commit: 308a259e55406134a1906f2ffa9591247fe2a594
    https://github.com/scummvm/scummvm/commit/308a259e55406134a1906f2ffa9591247fe2a594
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2021-05-31T09:24:24+03:00

Commit Message:
TRECISION: Fix some issues found by Coverity

Changed paths:
    engines/trecision/3d.cpp
    engines/trecision/scheduler.cpp
    engines/trecision/scheduler.h


diff --git a/engines/trecision/3d.cpp b/engines/trecision/3d.cpp
index f05f930fa0..f02b552714 100644
--- a/engines/trecision/3d.cpp
+++ b/engines/trecision/3d.cpp
@@ -1725,9 +1725,6 @@ void PathFinding3D::buildFramelist() {
 		curLen = oz + _vm->_actor->frameCenter(v) - firstFrame;
 	}
 
-	if (!a)
-		warning("buildFramelist - Unknown error: step number = 0");
-
 	// After the destination, add the stop frame
 
 	// if he was walking
diff --git a/engines/trecision/scheduler.cpp b/engines/trecision/scheduler.cpp
index 6a6efe629a..4b8730d2b4 100644
--- a/engines/trecision/scheduler.cpp
+++ b/engines/trecision/scheduler.cpp
@@ -29,7 +29,7 @@ Scheduler::Scheduler(TrecisionEngine *vm) : _vm(vm) {
 	_token = CLASS_CHAR;
 	_counter = 0;
 
-	_idleMsg = {MC_IDLE, 0, MP_DEFAULT, 0, 0, 0, 0, 0};
+	_idleMsg = { MC_IDLE, 0, MP_DEFAULT, 0, 0, 0, 0 };
 }
 
 Scheduler::~Scheduler() {
@@ -93,7 +93,6 @@ void Scheduler::doEvent(uint8 cls, uint8 event, uint8 priority,
 	m._u16Param2 = u16Param2;
 	m._u8Param = u8Param;
 	m._u32Param = u32Param;
-	m._timestamp = _vm->_curTime;
 
 	if (cls <= CLASS_GAME) {
 		_gameQueue.push_back(m);
diff --git a/engines/trecision/scheduler.h b/engines/trecision/scheduler.h
index f5040558bf..7228b516de 100644
--- a/engines/trecision/scheduler.h
+++ b/engines/trecision/scheduler.h
@@ -41,7 +41,6 @@ struct Message {
 	uint16 _u16Param1; // byte parameter 1
 	uint16 _u16Param2; // byte parameter 2
 	uint32 _u32Param;  // int parameter
-	uint32 _timestamp;
 
 	void set(Message *src) {
 		_class = src->_class;
@@ -51,7 +50,6 @@ struct Message {
 		_u16Param1 = src->_u16Param1;
 		_u16Param2 = src->_u16Param2;
 		_u32Param = src->_u32Param;
-		_timestamp = src->_timestamp;
 	}
 };
 




More information about the Scummvm-git-logs mailing list