[Scummvm-git-logs] scummvm master -> a10d723d255efaf1e6446a582bf2523ebd8b67fa

[bluegr]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a10d723d25 NGI: Fix memory leak in PictureObject


Commit: a10d723d255efaf1e6446a582bf2523ebd8b67fa
    https://github.com/scummvm/scummvm/commit/a10d723d255efaf1e6446a582bf2523ebd8b67fa
Author: Mathias Parnaudeau (mparnaudeau at optimum-software.fr)
Date: 2021-11-17T23:29:32+02:00

Commit Message:
NGI: Fix memory leak in PictureObject

The default destructor did not freed the picture data belonging
to the PictureObject instances, causing many memory leaks.

Changed paths:
    engines/ngi/gfx.cpp
    engines/ngi/gfx.h


diff --git a/engines/ngi/gfx.cpp b/engines/ngi/gfx.cpp
index 2552af96fb..823486829c 100644
--- a/engines/ngi/gfx.cpp
+++ b/engines/ngi/gfx.cpp
@@ -108,6 +108,10 @@ PictureObject::PictureObject(PictureObject *src) : GameObject(src) {
 	_objtype = kObjTypePictureObject;
 }
 
+PictureObject::~PictureObject() {
+	delete _picture;
+}
+
 bool PictureObject::load(MfcArchive &file, bool bigPicture) {
 	debugC(5, kDebugLoading, "PictureObject::load()");
 	GameObject::load(file);
diff --git a/engines/ngi/gfx.h b/engines/ngi/gfx.h
index e096104557..9a02bc64e7 100644
--- a/engines/ngi/gfx.h
+++ b/engines/ngi/gfx.h
@@ -167,6 +167,7 @@ class GameObject : public CObject {
 class PictureObject : public GameObject {
 public:
 	PictureObject();
+	~PictureObject();
 
 	PictureObject(PictureObject *src);