[Scummvm-git-logs] scummvm master -> 3d6fb5b60823ccc54c6e23747c960b83a1cd6b6e

bluegr noreply at scummvm.org
Wed Aug 24 22:18:11 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3d6fb5b608 SCUMM: Work around typo in Syd's biography in DOS Maniac Mansion (v1)


Commit: 3d6fb5b60823ccc54c6e23747c960b83a1cd6b6e
    https://github.com/scummvm/scummvm/commit/3d6fb5b60823ccc54c6e23747c960b83a1cd6b6e
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2022-08-25T01:18:07+03:00

Commit Message:
SCUMM: Work around typo in Syd's biography in DOS Maniac Mansion (v1)

In the English version, Syd's biography says that he's "tring" to start
his own new-wave band. Other versions I've seen (in person or on YouTube)
have either fixed the typo, or (in the case of the NES version)
completely rewritten the text. Fix this, and mark it as an enhancement.

Changed paths:
    engines/scumm/script_v2.cpp


diff --git a/engines/scumm/script_v2.cpp b/engines/scumm/script_v2.cpp
index 5ccaea0801c..99db95ce3d1 100644
--- a/engines/scumm/script_v2.cpp
+++ b/engines/scumm/script_v2.cpp
@@ -414,6 +414,20 @@ void ScummEngine_v2::decodeParseString() {
 		*ptr = 0;
 	}
 
+	// WORKAROUND: There is a typo in Syd's biography ("tring" instead of
+	// "trying") in the English DOS version of Maniac Mansion (v1). As far
+	// as I know, this is the only version with the typo.
+	else if (_game.id == GID_MANIAC && _game.version == 1
+		&& _game.platform == Common::kPlatformDOS
+		&& !(_game.features & GF_DEMO) && _language == Common::EN_ANY
+		&& vm.slot[_currentScript].number == 260 && _enableEnhancements
+		&& strncmp((char *)buffer + 26, " tring ", 7) == 0) {
+		for (byte *p = ptr; p >= buffer + 29; p--)
+			*(p + 1) = *p;
+
+		buffer[29] = 'y';
+	}
+
 	int textSlot = 0;
 	_string[textSlot].xpos = 0;
 	_string[textSlot].ypos = 0;




More information about the Scummvm-git-logs mailing list