[Scummvm-git-logs] scummvm master -> 25401cdf922ca629d8e6c8d8664a07b0c755b897

bluegr noreply at scummvm.org
Thu Jun 30 14:16:04 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
25401cdf92 GUI: Add missing domain when checking for subtitle config - bug #13629


Commit: 25401cdf922ca629d8e6c8d8664a07b0c755b897
    https://github.com/scummvm/scummvm/commit/25401cdf922ca629d8e6c8d8664a07b0c755b897
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2022-06-30T17:14:58+03:00

Commit Message:
GUI: Add missing domain when checking for subtitle config - bug #13629

This disallowed selecting "both" for speech and subtitles, as the
subtitles setting was never saved. A regression from d6dbf721b62e773f.

Changed paths:
    gui/options.cpp


diff --git a/gui/options.cpp b/gui/options.cpp
index 803c44f4776..2a9a7372268 100644
--- a/gui/options.cpp
+++ b/gui/options.cpp
@@ -965,7 +965,7 @@ void OptionsDialog::apply() {
 					break;
 				}
 
-				if (subtitles != ConfMan.getBool("subtitles")) {
+				if (subtitles != ConfMan.getBool("subtitles", _domain)) {
 					ConfMan.setBool("subtitles", subtitles, _domain);
 					_subToggleDesc->setFontColor(ThemeEngine::FontColor::kFontColorNormal); 
 				}




More information about the Scummvm-git-logs mailing list