[Scummvm-git-logs] scummvm master -> bedbc2881d2d6f7540b0552722c1e8f731d0f3f3

bluegr noreply at scummvm.org
Sun Nov 27 21:06:27 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
bedbc2881d TINSEL: Fix DW2 subtitle color on big-endian systems


Commit: bedbc2881d2d6f7540b0552722c1e8f731d0f3f3
    https://github.com/scummvm/scummvm/commit/bedbc2881d2d6f7540b0552722c1e8f731d0f3f3
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2022-11-27T23:06:24+02:00

Commit Message:
TINSEL: Fix DW2 subtitle color on big-endian systems

The red text for the Suffrajester in the cemetery was printed in black
on big-endian PowerPC.

It appears that the color given to SetActorRGB() is already in native
endianness, so there's no need to call TO_32() which would do a double
conversion on big-endian hosts.

Changed paths:
    engines/tinsel/actors.cpp


diff --git a/engines/tinsel/actors.cpp b/engines/tinsel/actors.cpp
index 1fc2bb6e025..200611813b4 100644
--- a/engines/tinsel/actors.cpp
+++ b/engines/tinsel/actors.cpp
@@ -1036,9 +1036,9 @@ void Actor::SetActorRGB(int ano, COLORREF color) {
 	assert(ano >= 0 && ano <= _numActors);
 
 	if (ano)
-		_actorInfo[ano - 1].textColor = TO_32(color);
+		_actorInfo[ano - 1].textColor = color;
 	else
-		_defaultColor = TO_32(color);
+		_defaultColor = color;
 }
 
 /**




More information about the Scummvm-git-logs mailing list