[Scummvm-git-logs] scummvm master -> e78a88e2fb649ba19af72d46e13651c2d58b8ee9

rvanlaar noreply at scummvm.org
Wed Oct 5 16:11:22 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e78a88e2fb TESTS: plug memory leaks


Commit: e78a88e2fb649ba19af72d46e13651c2d58b8ee9
    https://github.com/scummvm/scummvm/commit/e78a88e2fb649ba19af72d46e13651c2d58b8ee9
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-10-05T18:11:10+02:00

Commit Message:
TESTS: plug memory leaks

Use `clear` instead of `release` where possible.
Both clean up the span object. They differ in that `release` returns a pointer to
the internal data and `clear` destroys the internal data.

Changed paths:
    test/common/span.h


diff --git a/test/common/span.h b/test/common/span.h
index 1c1a0adcdac..3396c23b40d 100644
--- a/test/common/span.h
+++ b/test/common/span.h
@@ -263,7 +263,7 @@ public:
 			}
 
 			TS_ASSERT_EQUALS((bool)owner2, true);
-			owner2.release();
+			owner2.clear();
 			TS_ASSERT_EQUALS((bool)owner2, false);
 		}
 
@@ -280,7 +280,7 @@ public:
 			}
 
 			TS_ASSERT_EQUALS((bool)owner2, true);
-			owner2.release();
+			owner2.clear();
 			TS_ASSERT_EQUALS((bool)owner2, false);
 		}
 
@@ -359,7 +359,7 @@ public:
 			}
 
 			TS_ASSERT_EQUALS((bool)owner2, true);
-			owner2.release();
+			owner2.clear();
 			TS_ASSERT_EQUALS((bool)owner2, false);
 		}
 




More information about the Scummvm-git-logs mailing list