[Scummvm-git-logs] scummvm master -> 3c4d3a0d62624f01a55afc8542456eef6b27a923

lephilousophe noreply at scummvm.org
Sun Oct 23 18:14:32 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3c4d3a0d62 CI: Explicitly use the Bash shell on macOS and Linux


Commit: 3c4d3a0d62624f01a55afc8542456eef6b27a923
    https://github.com/scummvm/scummvm/commit/3c4d3a0d62624f01a55afc8542456eef6b27a923
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2022-10-23T20:14:27+02:00

Commit Message:
CI: Explicitly use the Bash shell on macOS and Linux

If it's just set implicitly, pipefail isn't enabled, but that's a
setting one almost always wants in a CI setup.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell

Changed paths:
    .github/workflows/ci.yml


diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c0844df86d4..0e826d6d66d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -112,6 +112,10 @@ jobs:
     env:
       BUILDCACHE_MAX_CACHE_SIZE: 2000000000
       BUILDCACHE_HARD_LINKS: true
+    defaults:
+      run:
+        # Must be explicit for proper pipefail support
+        shell: bash
     steps:
       - name: Checkout
         uses: actions/checkout at v2
@@ -140,7 +144,7 @@ jobs:
           cache_key: ${{ matrix.platform }}
       - name: Build scummvm
         run: |
-          set -o pipefail && xcodebuild CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ build -project scummvm.xcodeproj ${{ matrix.buildFlags }} | awk '$1 !~ /^(export|cd|clang++)/'
+          xcodebuild CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ build -project scummvm.xcodeproj ${{ matrix.buildFlags }} | awk '$1 !~ /^(export|cd|clang++)/'
           ls
   ubuntu:
     name: Ubuntu
@@ -159,6 +163,10 @@ jobs:
             aptPackages: 'g++-4.8 libsdl1.2-dev libsdl-net1.2-dev liba52-dev libjpeg-turbo8-dev libmpeg2-4-dev libogg-dev libvorbis-dev libflac-dev libmad0-dev libpng-dev libtheora-dev libfaad-dev libfluidsynth-dev libfreetype6-dev zlib1g-dev libfribidi-dev libcurl4-openssl-dev libgtk-3-dev libspeechd-dev libsndio-dev libunity-dev'
     env:
       SDL_CONFIG: ${{ matrix.sdlConfig }}
+    defaults:
+      run:
+        # Must be explicit for proper pipefail support
+        shell: bash
     steps:
       - name: Checkout
         uses: actions/checkout at v2




More information about the Scummvm-git-logs mailing list