[Scummvm-git-logs] scummvm master -> 76da8b7f3a6f1f035448abdb639b9b4bdaa357a0

rvanlaar noreply at scummvm.org
Tue Sep 20 19:13:05 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
76da8b7f3a JANITORIAL: BACKENDS: MIDI: Add override keywords


Commit: 76da8b7f3a6f1f035448abdb639b9b4bdaa357a0
    https://github.com/scummvm/scummvm/commit/76da8b7f3a6f1f035448abdb639b9b4bdaa357a0
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-09-20T21:12:35+02:00

Commit Message:
JANITORIAL: BACKENDS: MIDI: Add override keywords

Mark MidiDriver_Sndio and MidiDriver_ALSA overridden methods
with override.

Removes compile warnings:
`overrides a member function but is not marked 'override'`
when building with clang.

Changed paths:
    backends/midi/alsa.cpp
    backends/midi/sndio.cpp


diff --git a/backends/midi/alsa.cpp b/backends/midi/alsa.cpp
index fba8d57d621..f2591b60332 100644
--- a/backends/midi/alsa.cpp
+++ b/backends/midi/alsa.cpp
@@ -69,11 +69,11 @@ static int check_permission(snd_seq_port_info_t *pinfo) {
 class MidiDriver_ALSA : public MidiDriver_MPU401 {
 public:
 	MidiDriver_ALSA(int client, int port);
-	int open();
-	bool isOpen() const { return _isOpen; }
-	void close();
+	int open() override;
+	bool isOpen() const override { return _isOpen; }
+	void close() override;
 	void send(uint32 b) override;
-	void sysEx(const byte *msg, uint16 length);
+	void sysEx(const byte *msg, uint16 length) override;
 
 private:
 	void send_event(int do_flush);
diff --git a/backends/midi/sndio.cpp b/backends/midi/sndio.cpp
index 91390472f35..d629420e85b 100644
--- a/backends/midi/sndio.cpp
+++ b/backends/midi/sndio.cpp
@@ -43,11 +43,11 @@
 class MidiDriver_Sndio : public MidiDriver_MPU401 {
 public:
 	MidiDriver_Sndio();
-	int open();
-	bool isOpen() const { return hdl != NULL; }
-	void close();
+	int open() override;
+	bool isOpen() const override { return hdl != NULL; }
+	void close() override;
 	void send(uint32 b) override;
-	void sysEx(const byte *msg, uint16 length);
+	void sysEx(const byte *msg, uint16 length) override;
 
 private:
 	struct mio_hdl *hdl;




More information about the Scummvm-git-logs mailing list