[Scummvm-git-logs] scummvm master -> 7956cd19f9e12edcd527265d18e5e79fee568ed2

[AndywinXp]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
7956cd19f9 SCUMM: HE: Fix Coverity #1544405


Commit: 7956cd19f9e12edcd527265d18e5e79fee568ed2
    https://github.com/scummvm/scummvm/commit/7956cd19f9e12edcd527265d18e5e79fee568ed2
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-04-29T19:44:01+02:00

Commit Message:
SCUMM: HE: Fix Coverity #1544405

Changed paths:
    engines/scumm/akos.cpp


diff --git a/engines/scumm/akos.cpp b/engines/scumm/akos.cpp
index 9e2f4e93fb7..4da48a9458a 100644
--- a/engines/scumm/akos.cpp
+++ b/engines/scumm/akos.cpp
@@ -1158,7 +1158,7 @@ byte AkosRenderer::hePaintCel(int actor, int drawToBack, int celX, int celY, int
 							  const WizRawPixel *conversionTable, int32 specialRenderFlags) {
 
 	int plotX, plotY;
-	bool xFlipFlag, yFlipFlag;
+	bool xFlipFlag;
 	Common::Rect destRect;
 	Common::Rect sourceRect;
 	Common::Rect clipRect;
@@ -1168,10 +1168,9 @@ byte AkosRenderer::hePaintCel(int actor, int drawToBack, int celX, int celY, int
 	Actor *a = _vm->derefActor(actor, "hePaintCel");
 
 	if (allowFlip) {
-		yFlipFlag = false;
 		xFlipFlag = _mirror;
 	} else {
-		xFlipFlag = yFlipFlag = false;
+		xFlipFlag = false;
 	}
 
 	// Find cel's "plot" position with flipping etc...
@@ -1229,12 +1228,7 @@ byte AkosRenderer::hePaintCel(int actor, int drawToBack, int celX, int celY, int
 
 		//SetActorUpdateArea(actor, destRect.x1, destRect.y1, destRect.x2, destRect.y2);
 
-		// Get final plot point and flip source coords if necessary.
-		if (yFlipFlag) {
-			wiz->swapRectY(&sourceRect);
-			sourceRect.top = (celHeight - 1) - sourceRect.top;
-			sourceRect.bottom = (celHeight - 1) - sourceRect.bottom;
-		}
+		// Get final plot point and flip source coords if necessary...
 		if (xFlipFlag) {
 			wiz->swapRectX(&sourceRect);
 			sourceRect.left = (celWidth - 1) - sourceRect.left;