[Scummvm-git-logs] scummvm master -> 99df4686efeac99836abaf05d92a01679cbeb924

AndywinXp noreply at scummvm.org
Mon Apr 29 17:51:07 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
99df4686ef SCUMM: HE: Fix Coverity #1544404


Commit: 99df4686efeac99836abaf05d92a01679cbeb924
    https://github.com/scummvm/scummvm/commit/99df4686efeac99836abaf05d92a01679cbeb924
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-04-29T19:51:01+02:00

Commit Message:
SCUMM: HE: Fix Coverity #1544404

Changed paths:
    engines/scumm/he/sprite_he.cpp


diff --git a/engines/scumm/he/sprite_he.cpp b/engines/scumm/he/sprite_he.cpp
index 47a89ca9754..fa1c6efc48d 100644
--- a/engines/scumm/he/sprite_he.cpp
+++ b/engines/scumm/he/sprite_he.cpp
@@ -1672,14 +1672,14 @@ void Sprite::buildActiveSpriteList() {
 }
 
 WizSimpleBitmap *Sprite::getSimpleBitmapForSprite(const SpriteInfo *spritePtr) {
-	WizSimpleBitmap *simpleBitmap = nullptr;
+	WizSimpleBitmap simpleBitmap;
 	int image = spritePtr->image;
 	int group = spritePtr->group;
 	int groupImage = _groupTable[group].image;
 
 	if (image != 0 && group != 0 && groupImage != 0) {
-		if (_vm->_wiz->dwSetSimpleBitmapStructFromImage(groupImage, 0, simpleBitmap)) {
-			return simpleBitmap;
+		if (_vm->_wiz->dwSetSimpleBitmapStructFromImage(groupImage, 0, &simpleBitmap)) {
+			return &simpleBitmap;
 		}
 	}
 




More information about the Scummvm-git-logs mailing list