[Scummvm-git-logs] scummvm master -> 947ac793564fdb177cb26ef6835abf8598da6cea

AndywinXp noreply at scummvm.org
Mon Apr 29 18:04:07 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
947ac79356 SCUMM: HE: Fix Coverity #1544408


Commit: 947ac793564fdb177cb26ef6835abf8598da6cea
    https://github.com/scummvm/scummvm/commit/947ac793564fdb177cb26ef6835abf8598da6cea
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-04-29T20:04:01+02:00

Commit Message:
SCUMM: HE: Fix Coverity #1544408

Changed paths:
    engines/scumm/he/wiz_he.cpp


diff --git a/engines/scumm/he/wiz_he.cpp b/engines/scumm/he/wiz_he.cpp
index bd2a67b441c..f066479de20 100644
--- a/engines/scumm/he/wiz_he.cpp
+++ b/engines/scumm/he/wiz_he.cpp
@@ -2316,12 +2316,15 @@ void Wiz::ensureNativeFormatImageForState(int image, int state) {
 
 		int newCompType = compType;
 		switch (compType) {
-		case kWCTNone16Bpp:
-			newCompType += kWCTNone16BppBigEndian - kWCTNone16Bpp;
-			break;
-		case kWCTTRLE16Bpp:
-			newCompType += kWCTTRLE16BppBigEndian - kWCTTRLE16Bpp;
-			break;
+		// These were in the original but they appear to be dead code.
+		// Not removing these just yet...
+		// 
+		// case kWCTNone16Bpp:
+		// 	newCompType += kWCTNone16BppBigEndian - kWCTNone16Bpp;
+		// 	break;
+		// case kWCTTRLE16Bpp:
+		// 	newCompType += kWCTTRLE16BppBigEndian - kWCTTRLE16Bpp;
+		// 	break;
 		case kWCTNone16BppBigEndian:
 			newCompType -= kWCTNone16BppBigEndian - kWCTNone16Bpp;
 			break;




More information about the Scummvm-git-logs mailing list