[Scummvm-git-logs] scummvm branch-2-9 -> 493e75f3703981849a37bf5cf813db40f4857eac

[mistydemeo]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
493e75f370 DIRECTOR: remove redundant string decode


Commit: 493e75f3703981849a37bf5cf813db40f4857eac
    https://github.com/scummvm/scummvm/commit/493e75f3703981849a37bf5cf813db40f4857eac
Author: Misty De Meo (mistydemeo at gmail.com)
Date: 2024-11-20T18:38:29+08:00

Commit Message:
DIRECTOR: remove redundant string decode

The string is already decoded by the time it makes its way into the
alert; decoding it again will just garble any non-ASCII encoding.

Changed paths:
    engines/director/lingo/lingo-builtins.cpp


diff --git a/engines/director/lingo/lingo-builtins.cpp b/engines/director/lingo/lingo-builtins.cpp
index 46aef678659..f930fdc1bff 100644
--- a/engines/director/lingo/lingo-builtins.cpp
+++ b/engines/director/lingo/lingo-builtins.cpp
@@ -2027,7 +2027,7 @@ void LB::b_alert(int nargs) {
 
 	if (!debugChannelSet(-1, kDebugFewFramesOnly)) {
 		g_director->_wm->clearHandlingWidgets();
-		GUI::MessageDialog dialog(g_director->getCurrentMovie()->getCast()->decodeString(alert), _("OK"));
+		GUI::MessageDialog dialog(alert.c_str(), _("OK"));
 		dialog.runModal();
 	}
 }