[Scummvm-git-logs] scummvm master -> e70029ce796dd206ac4de0bae8937ae1ee94142e

AndywinXp noreply at scummvm.org
Tue Sep 17 08:55:03 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e70029ce79 SCUMM: BASKETBALL: Fix oversight in court data parsing


Commit: e70029ce796dd206ac4de0bae8937ae1ee94142e
    https://github.com/scummvm/scummvm/commit/e70029ce796dd206ac4de0bae8937ae1ee94142e
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-09-17T10:54:57+02:00

Commit Message:
SCUMM: BASKETBALL: Fix oversight in court data parsing

sluicebox to the rescue... :P

Changed paths:
    engines/scumm/he/basketball/collision/bball_collision.cpp


diff --git a/engines/scumm/he/basketball/collision/bball_collision.cpp b/engines/scumm/he/basketball/collision/bball_collision.cpp
index 389c8c19c08..75669cf2b9d 100644
--- a/engines/scumm/he/basketball/collision/bball_collision.cpp
+++ b/engines/scumm/he/basketball/collision/bball_collision.cpp
@@ -68,7 +68,7 @@ int LogicHEBasketball::u32_userInitCourt(int courtID) {
 	char fileVersion[32];
 	int versionStringLength = objectFile.readUint32LE();
 
-	if (versionStringLength <= 0 && versionStringLength > ARRAYSIZE(fileVersion) - 1)
+	if (versionStringLength <= 0 || versionStringLength > ARRAYSIZE(fileVersion) - 1)
 		error("LogicHEBasketball::u32_userInitCourt(): Read from stream did not read the version string length correctly.");
 	
 	objectFile.read(fileVersion, versionStringLength);




More information about the Scummvm-git-logs mailing list