[Scummvm-git-logs] scummvm master -> ea163ea91e0f28170d916760c1a38ac29ac3f5a2

[dwatteau]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ec4607af45 SCUMM: INDY3: Mention Trac#5597 in the detection code for broken "ryf's Indy3act"
ea163ea91e SCUMM: JANITORIAL: Update some comments regarding the "sign fixes" for MI1


Commit: ec4607af459420b53c1277301fb83acf1b1fa895
    https://github.com/scummvm/scummvm/commit/ec4607af459420b53c1277301fb83acf1b1fa895
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2025-04-02T15:28:42+02:00

Commit Message:
SCUMM: INDY3: Mention Trac#5597 in the detection code for broken "ryf's Indy3act"

I've checked the contents of the indy3-vga.s01 save which had been provided
in that bug report back then.  It was really coming from this very-badly
patched fan translation, since the save file contains some very bad
grammar/translations unique to that version.

This confirms that some users still had this release in their collection
in 2011, and that it's important to detect it so that people are aware
of it being effectively broken.

Changed paths:
    engines/scumm/metaengine.cpp


diff --git a/engines/scumm/metaengine.cpp b/engines/scumm/metaengine.cpp
index 97970d00d37..288b8993d4b 100644
--- a/engines/scumm/metaengine.cpp
+++ b/engines/scumm/metaengine.cpp
@@ -372,7 +372,8 @@ Common::Error ScummMetaEngine::createInstance(OSystem *syst, Engine **engine,
 	//
 	// One such example is a French translation of Indy3 VGA (ca. 2001-2002),
 	// known as "ryf's Indy3act", which contains corrupted opcodes in at least
-	// 07.LFL, 34.LFL and 72.LFL.
+	// 07.LFL, 34.LFL and 72.LFL. See bug #5597 as an example of the fatal
+	// errors it introduced.
 	if (res.md5 == "1875b90fade138c9253a8e967007031a" && !strcmp(res.game.gameid, "indy3") && res.game.platform == Common::kPlatformDOS && (res.game.features & GF_OLD256)) {
 		Common::String md5OtherRes;
 		Common::FSNode resFile;


Commit: ea163ea91e0f28170d916760c1a38ac29ac3f5a2
    https://github.com/scummvm/scummvm/commit/ea163ea91e0f28170d916760c1a38ac29ac3f5a2
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2025-04-02T15:40:20+02:00

Commit Message:
SCUMM: JANITORIAL: Update some comments regarding the "sign fixes" for MI1

Some stuff was moved with commit ad201e3b3eded4d7203bd49c4df398881b2892b5.
Update the comments referencing its previous location.

Changed paths:
    engines/scumm/gfx.cpp
    engines/scumm/script_v5.cpp


diff --git a/engines/scumm/gfx.cpp b/engines/scumm/gfx.cpp
index 279cf291852..44dcdf22f9b 100644
--- a/engines/scumm/gfx.cpp
+++ b/engines/scumm/gfx.cpp
@@ -2506,11 +2506,12 @@ bool Gdi::drawStrip(byte *dstPtr, VirtScreen *vs, int x, int y, const int width,
 
 	// WORKAROUND: In the French VGA floppy version of MI1, the easter egg
 	// poking fun at Sierra has a dark blue background instead of white,
-	// which causes similar legibility issues (the other VGA floppy
-	// translations are fine, and the French VGA Amiga and CD releases
-	// fixed this).
-
-	else if (_vm->_game.id == GID_MONKEY_VGA &&
+	// which causes legibility issues (similar to the ones with the sign
+	// about the dogs "only sleeping", which we already fix elsewhere).
+	//
+	// The other VGA floppy translations are fine, and the issue was
+	// fixed in the French VGA Amiga and CD releases.
+	if (_vm->_game.id == GID_MONKEY_VGA &&
 			_vm->_language == Common::FR_FRA &&
 			_vm->_game.platform != Common::kPlatformAmiga &&
 			_vm->_currentRoom == 11 &&
diff --git a/engines/scumm/script_v5.cpp b/engines/scumm/script_v5.cpp
index 07eb71b54f8..02b644767c8 100644
--- a/engines/scumm/script_v5.cpp
+++ b/engines/scumm/script_v5.cpp
@@ -3342,7 +3342,7 @@ void ScummEngine_v5::decodeParseString() {
 			// requires changing the color of the background, not the
 			// text.
 			//
-			// See also the related Gdi::drawStrip() workaround.
+			// See also the related ScummEngine::startScene() workaround.
 
 			else if (_game.id == GID_MONKEY &&
 					!(_game.features & GF_ULTIMATE_TALKIE) &&