[Scummvm-git-logs] scummvm master -> c1ee7cfe7a781c0752238d43da30abce84eddc7c

[digitall]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
c1ee7cfe7a COMMON: Fix Case of Invalid Read When Reading PE Executable


Commit: c1ee7cfe7a781c0752238d43da30abce84eddc7c
    https://github.com/scummvm/scummvm/commit/c1ee7cfe7a781c0752238d43da30abce84eddc7c
Author: D G Turner (digitall at scummvm.org)
Date: 2025-06-30T03:21:45+01:00

Commit Message:
COMMON: Fix Case of Invalid Read When Reading PE Executable

This was detected with valgrind while working on DIRECTOR engine.

Changed paths:
    common/formats/winexe_pe.cpp


diff --git a/common/formats/winexe_pe.cpp b/common/formats/winexe_pe.cpp
index 526ae26403b..65db10ee032 100644
--- a/common/formats/winexe_pe.cpp
+++ b/common/formats/winexe_pe.cpp
@@ -274,6 +274,9 @@ WinResources::VersionInfo *PEResources::parseVersionInfo(SeekableReadStream *res
 		uint16 type = res->readUint16LE();
 		uint16 c;
 
+		if (res->eos())
+			break;
+
 		Common::U32String key;
 		while ((c = res->readUint16LE()) != 0 && !res->eos())
 			key += c;