[Scummvm-git-logs] scummvm master -> fe142ede1a7a48f70da84175a7024547fa2880e3

criezy noreply at scummvm.org
Wed May 14 22:27:15 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
fe142ede1a BASE: Fix MetaEngine leak in runGame


Commit: fe142ede1a7a48f70da84175a7024547fa2880e3
    https://github.com/scummvm/scummvm/commit/fe142ede1a7a48f70da84175a7024547fa2880e3
Author: tunnelsociety (150493071+tunnelsociety at users.noreply.github.com)
Date: 2025-05-14T23:27:12+01:00

Commit Message:
BASE: Fix MetaEngine leak in runGame

metaEngine could have been issued createInstance but not deleteInstance
if an engine failed to instantiate (e.g. if user cancels start of a
not-fully-supported game).

Changed paths:
    base/main.cpp


diff --git a/base/main.cpp b/base/main.cpp
index f1fa30eac0f..9676d24036a 100644
--- a/base/main.cpp
+++ b/base/main.cpp
@@ -236,6 +236,8 @@ static Common::Error runGame(const Plugin *enginePlugin, OSystem &system, const
 			ConfMan.removeGameDomain(target.c_str());
 		}
 
+		metaEngine.deleteInstance(engine, game, meDescriptor);
+
 		return err;
 	}
 




More information about the Scummvm-git-logs mailing list