[Scummvm-git-logs] scummvm master -> 00782713616ce9fc25652eeccd477d6704a86f9a

[dwatteau]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
0078271361 SCUMM: Document that for Trac#1607 we don't match original interpreter behavior


Commit: 00782713616ce9fc25652eeccd477d6704a86f9a
    https://github.com/scummvm/scummvm/commit/00782713616ce9fc25652eeccd477d6704a86f9a
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2025-05-23T14:56:18+02:00

Commit Message:
SCUMM: Document that for Trac#1607 we don't match original interpreter behavior

I've tested this part of Indy4 with the original interpreter running
in DOSBox and DREAMM, and I've also checked this scene with the 2009
interpreter (based on Aaron's work).

There, the object does *not* get renamed, as can been seen on our
side. So we still need this script workaround to observe the same
behavior as the original.

So we may have a small accuracy issue here, but I can't say if it's
important. In any case, it might be good to document the difference.

Changed paths:
    engines/scumm/script.cpp


diff --git a/engines/scumm/script.cpp b/engines/scumm/script.cpp
index 2d8c22d6c0d..9825fe07054 100644
--- a/engines/scumm/script.cpp
+++ b/engines/scumm/script.cpp
@@ -1112,9 +1112,8 @@ void ScummEngine::killScriptsAndResources() {
 					// the pegs may be renamed to mouth: this custom name is lost
 					// when leaving the room; this hack prevents this).
 					//
-					// TODO: investigate this bug report from 2004, and see if the
-					// issue appears with an original interpreter, and with our current
-					// (much more accurate) SCUMMv5 implementation.
+					// TODO: This does *not* happen with the original interpreter,
+					// or with the 2009 (Aaron Giles) one!
 					if (owner == OF_OWNER_ROOM && _game.id == GID_INDY4 && 336 <= obj && obj <= 340)
 						continue;