[Scummvm-git-logs] scummvm master -> eb4b3f02afc5a7f09efefe9a794dfdaf707ad385

[lephilousophe]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
eb4b3f02af AUDIO: Add a comment to explain the cleanup in 9b90d72


Commit: eb4b3f02afc5a7f09efefe9a794dfdaf707ad385
    https://github.com/scummvm/scummvm/commit/eb4b3f02afc5a7f09efefe9a794dfdaf707ad385
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2025-11-04T20:45:22+01:00

Commit Message:
AUDIO: Add a comment to explain the cleanup in 9b90d72

Changed paths:
    audio/softsynth/fluidsynth.cpp


diff --git a/audio/softsynth/fluidsynth.cpp b/audio/softsynth/fluidsynth.cpp
index f511386a3df..4371aea495e 100644
--- a/audio/softsynth/fluidsynth.cpp
+++ b/audio/softsynth/fluidsynth.cpp
@@ -517,6 +517,15 @@ void MidiDriver_FluidSynth::close() {
 
 	_mixer->stopHandle(_mixerSoundHandle);
 
+	/*
+	 * Don't delete the soundfont before cleaning up
+	 * Some parts of it are still in use and cause a timer thread to be
+	 * created to postpone the cleanup.
+	 * The "embedded" OS abstraction layer introduced in Fluidsynth 2.5 does
+	 * not supported threads and this causes a segfault when the final cleanup happens
+	 * just below.
+	 */
+
 	delete_fluid_synth(_synth);
 	delete_fluid_settings(_settings);
 }