[Scummvm-git-logs] scummvm master -> 3973113e3753598169c3e90f95f7b1a6bd248c68

[neuromancer]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
b54e67c635 PRIVATE: fixed sign-compare warning
3973113e37 PRIVATE: disable the highlight decision area feature by default


Commit: b54e67c6359752430281940a5af830ac63a85d0f
    https://github.com/scummvm/scummvm/commit/b54e67c6359752430281940a5af830ac63a85d0f
Author: neuromancer (gustavo.grieco at gmail.com)
Date: 2025-11-10T08:58:36+01:00

Commit Message:
PRIVATE: fixed sign-compare warning

Changed paths:
    engines/private/private.cpp
    engines/private/private.h


diff --git a/engines/private/private.cpp b/engines/private/private.cpp
index 91344882716..9ff22b7fb93 100644
--- a/engines/private/private.cpp
+++ b/engines/private/private.cpp
@@ -53,7 +53,7 @@ extern int parse(const char *);
 PrivateEngine::PrivateEngine(OSystem *syst, const ADGameDescription *gd)
 	: Engine(syst), _gameDescription(gd), _image(nullptr), _videoDecoder(nullptr),
 	  _compositeSurface(nullptr), _transparentColor(0), _frameImage(nullptr),
-	  _framePalette(nullptr), _maxNumberClicks(0), _sirenWarning(0), 
+	  _framePalette(nullptr), _maxNumberClicks(0), _sirenWarning(0),
 	  _subtitles(nullptr), _sfxSubtitles(false), _useSubtitles(false),
 	  _defaultCursor(nullptr),
 	  _screenW(640), _screenH(480) {
@@ -862,7 +862,7 @@ bool PrivateEngine::selectLocation(const Common::Point &mousePos) {
 	}
 
 	uint i = 0;
-	uint totalLocations = 0;
+	int totalLocations = 0;
 	for (auto &it : maps.locationList) {
 		const Private::Symbol *sym = maps.locations.getVal(it);
 		if (sym->u.val) {
diff --git a/engines/private/private.h b/engines/private/private.h
index 0e9a23420db..2efef82bf48 100644
--- a/engines/private/private.h
+++ b/engines/private/private.h
@@ -134,7 +134,7 @@ typedef struct MemoryInfo {
 typedef struct DiaryPage {
 	Common::String locationName;
 	Common::Array<MemoryInfo> memories;
-	uint locationID;
+	int locationID;
 } DiaryPage;
 
 // funcs


Commit: 3973113e3753598169c3e90f95f7b1a6bd248c68
    https://github.com/scummvm/scummvm/commit/3973113e3753598169c3e90f95f7b1a6bd248c68
Author: neuromancer (gustavo.grieco at gmail.com)
Date: 2025-11-10T09:08:15+01:00

Commit Message:
PRIVATE: disable the highlight decision area feature by default

Changed paths:
    engines/private/metaengine.cpp


diff --git a/engines/private/metaengine.cpp b/engines/private/metaengine.cpp
index e53a0b54422..c45f54a2d95 100644
--- a/engines/private/metaengine.cpp
+++ b/engines/private/metaengine.cpp
@@ -48,7 +48,7 @@ static const ADExtraGuiOptionsMap optionsList[] = {
 			_s("Highlight decision areas"),
 			_s("Highlight clickable areas in decision scenes."),
 			"highlightMasks",
-			true,
+			false,
 			0,
 			0
 		}