[Scummvm-git-logs] scummvm master -> 8dbb9ddc40cb3ef6ada110fc261f0ba10dcb94c0

[eriktorbjorn]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
8dbb9ddc40 SCUMM: Fix Valgrind warning in getInternalGUIControlFromCoordinates()


Commit: 8dbb9ddc40cb3ef6ada110fc261f0ba10dcb94c0
    https://github.com/scummvm/scummvm/commit/8dbb9ddc40cb3ef6ada110fc261f0ba10dcb94c0
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2025-09-13T07:53:54+02:00

Commit Message:
SCUMM: Fix Valgrind warning in getInternalGUIControlFromCoordinates()

This would happen e.g. when pausing a game, possibly only when ScummVM
was compiled with text to speech.

Changed paths:
    engines/scumm/gfx_gui.cpp


diff --git a/engines/scumm/gfx_gui.cpp b/engines/scumm/gfx_gui.cpp
index 713670be0ee..636c4398001 100644
--- a/engines/scumm/gfx_gui.cpp
+++ b/engines/scumm/gfx_gui.cpp
@@ -92,6 +92,10 @@ Common::KeyState ScummEngine::showBannerAndPause(int bannerId, int32 waitTime, c
 
 	_messageBannerActive = true;
 
+	for (int i = 0; i < ARRAYSIZE(_internalGUIControls); i++) {
+		_internalGUIControls[i].relativeCenterX = -1;
+	}
+
 	int oldScreenTop = _screenTop;
 
 	// There are a few instances in a non-zero _screenTop is not being reset
@@ -463,6 +467,10 @@ Common::KeyState ScummEngine::showOldStyleBannerAndPause(const char *msg, int co
 
 	_messageBannerActive = true;
 
+	for (int i = 0; i < ARRAYSIZE(_internalGUIControls); i++) {
+		_internalGUIControls[i].relativeCenterX = -1;
+	}
+
 	// Fetch the translated string for the message...
 	convertMessageToString((const byte *)msg, (byte *)bannerMsg, sizeof(bannerMsg));