[Scummvm-git-logs] scummvm master -> c74633e4bc32a56dfaac0bf31aec439d2bb86378

[AndywinXp]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
c74633e4bc SCUMM: Revert "Fix Valgrind warning in getInternalGUIControlFromCoordinates()"


Commit: c74633e4bc32a56dfaac0bf31aec439d2bb86378
    https://github.com/scummvm/scummvm/commit/c74633e4bc32a56dfaac0bf31aec439d2bb86378
Author: AndywinXp (andywinxp at gmail.com)
Date: 2025-09-13T08:03:28+02:00

Commit Message:
SCUMM: Revert "Fix Valgrind warning in getInternalGUIControlFromCoordinates()"

Sorry about that, but this breaks menus in most games.

Changed paths:
    engines/scumm/gfx_gui.cpp


diff --git a/engines/scumm/gfx_gui.cpp b/engines/scumm/gfx_gui.cpp
index 636c4398001..713670be0ee 100644
--- a/engines/scumm/gfx_gui.cpp
+++ b/engines/scumm/gfx_gui.cpp
@@ -92,10 +92,6 @@ Common::KeyState ScummEngine::showBannerAndPause(int bannerId, int32 waitTime, c
 
 	_messageBannerActive = true;
 
-	for (int i = 0; i < ARRAYSIZE(_internalGUIControls); i++) {
-		_internalGUIControls[i].relativeCenterX = -1;
-	}
-
 	int oldScreenTop = _screenTop;
 
 	// There are a few instances in a non-zero _screenTop is not being reset
@@ -467,10 +463,6 @@ Common::KeyState ScummEngine::showOldStyleBannerAndPause(const char *msg, int co
 
 	_messageBannerActive = true;
 
-	for (int i = 0; i < ARRAYSIZE(_internalGUIControls); i++) {
-		_internalGUIControls[i].relativeCenterX = -1;
-	}
-
 	// Fetch the translated string for the message...
 	convertMessageToString((const byte *)msg, (byte *)bannerMsg, sizeof(bannerMsg));