[Scummvm-git-logs] scummvm master -> 9a104674b7e3064dd26f76068eff24992f9daf5c

[dwatteau]

This automated email contains information about 3 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
5f395e34b5 DARKSEED: Silence Clang warning about unused-but-set variable
c8653c969f LASTEXPRESS: Silence Clang warning about unused-but-set variable
9a104674b7 MM: XEEN: Silence Clang warning about unused kTrainingButtonCount


Commit: 5f395e34b5c13f3b7168a42765ac1707e4ed4f9d
    https://github.com/scummvm/scummvm/commit/5f395e34b5c13f3b7168a42765ac1707e4ed4f9d
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2026-04-08T15:14:54+02:00

Commit Message:
DARKSEED: Silence Clang warning about unused-but-set variable

Changed paths:
    engines/darkseed/midiparser_sbr.cpp


diff --git a/engines/darkseed/midiparser_sbr.cpp b/engines/darkseed/midiparser_sbr.cpp
index 4a5459cef4d..c9d26d4e7d2 100644
--- a/engines/darkseed/midiparser_sbr.cpp
+++ b/engines/darkseed/midiparser_sbr.cpp
@@ -230,7 +230,6 @@ bool MidiParser_SBR::loadMusic(const byte *data, uint32 size) {
 	uint16 bytesRead = 0;
 	for (int i = 0; i < endTrack; i++) {
 		const byte *startOfTrack = data;
-		uint16 trackSize = 0;
 
 		bool foundEndOfTrack = false;
 		while (bytesRead < size) {
@@ -238,13 +237,11 @@ bool MidiParser_SBR::loadMusic(const byte *data, uint32 size) {
 			if (eventType == 0) {
 				foundEndOfTrack = true;
 				data++;
-				trackSize++;
 				bytesRead++;
 				break;
 			}
 			else {
 				data += 6;
-				trackSize += 6;
 				bytesRead += 6;
 			}
 		}


Commit: c8653c969f3c1e6437bb999a5ebf4bbfe4ae3ef0
    https://github.com/scummvm/scummvm/commit/c8653c969f3c1e6437bb999a5ebf4bbfe4ae3ef0
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2026-04-08T15:15:11+02:00

Commit Message:
LASTEXPRESS: Silence Clang warning about unused-but-set variable

Changed paths:
    engines/lastexpress/debug.cpp


diff --git a/engines/lastexpress/debug.cpp b/engines/lastexpress/debug.cpp
index 464701a24a6..6d852c8ec44 100644
--- a/engines/lastexpress/debug.cpp
+++ b/engines/lastexpress/debug.cpp
@@ -519,7 +519,6 @@ void LogicManager::renderCurrentSceneDebugger() {
 
 			// Draw collision lines...
 			Line7 *currentLine = currentLink->lineList;
-			int lineIndex = 0;
 			while (currentLine) {
 				ImU32 lineColor = IM_COL32(0, 255, 255, 255);
 
@@ -580,7 +579,6 @@ void LogicManager::renderCurrentSceneDebugger() {
 				}
 
 				currentLine = currentLine->next;
-				lineIndex++;
 			}
 
 			currentLink = currentLink->next;


Commit: 9a104674b7e3064dd26f76068eff24992f9daf5c
    https://github.com/scummvm/scummvm/commit/9a104674b7e3064dd26f76068eff24992f9daf5c
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2026-04-08T15:16:52+02:00

Commit Message:
MM: XEEN: Silence Clang warning about unused kTrainingButtonCount

Changed paths:
    engines/mm/xeen/locations.cpp


diff --git a/engines/mm/xeen/locations.cpp b/engines/mm/xeen/locations.cpp
index 1e5052362b0..60becc5e66f 100644
--- a/engines/mm/xeen/locations.cpp
+++ b/engines/mm/xeen/locations.cpp
@@ -42,7 +42,7 @@ namespace Locations {
 
 	static const uint8 kTempleOptionsCount = 3;
 
-	static const uint8 kTrainingButtonCount = 2;
+	//static const uint8 kTrainingButtonCount = 2;
 	static const uint8 kTrainingIneligibleInfoCount = 2;
 	static const uint8 kTrainingEligibleInfoCount = 4;
 #endif