[Scummvm-git-logs] scummvm master -> e6d6426d7d27376b63ad07a42f1ba7634eb21d97

[orgads]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
e6d6426d7d JANITORIAL: Fix compiler warnings


Commit: e6d6426d7d27376b63ad07a42f1ba7634eb21d97
    https://github.com/scummvm/scummvm/commit/e6d6426d7d27376b63ad07a42f1ba7634eb21d97
Author: Orgad Shaneh (orgads at gmail.com)
Date: 2026-01-17T21:56:30+02:00

Commit Message:
JANITORIAL: Fix compiler warnings

In member function 'MidiParser_HMP::HmpVersion MidiParser_HMP::determineVersion(const byte*)',
    inlined from 'virtual int32 MidiParser_HMP::determineDataSize(Common::SeekableReadStream*)' at audio/midiparser_hmp.cpp:132:39:
audio/midiparser_hmp.cpp:161:129: warning: 'versionBytes' may be used uninitialized [-Wmaybe-uninitialized]
  161 |                 warning("Unknown HMP version '%c%c%c%c%c%c' - assuming version 1", pos[0], pos[1], pos[2], pos[3], pos[4], pos[5]);
      |                                                                                                                            ~~~~~^
audio/midiparser_hmp.cpp: In member function 'virtual int32 MidiParser_HMP::determineDataSize(Common::SeekableReadStream*)':
audio/midiparser_hmp.cpp:130:14: note: 'versionBytes' declared here
  130 |         byte versionBytes[6];
      |              ^~~~~~~~~~~~
gui/widgets/list.cpp: In member function 'void GUI::ListWidget::addSelectedItem(int)':
gui/widgets/list.cpp:228:27: warning: comparison of integer expressions of different signedness: 'int' and 'Common::Array<int>::size_type' {aka 'unsigned int'} [-Wsign-compare]
  228 |         for (int i = 0; i < _selectedItems.size(); ++i) {
      |                         ~~^~~~~~~~~~~~~~~~~~~~~~~
gui/widgets/list.cpp: In member function 'void GUI::ListWidget::removeSelectedItem(int)':
gui/widgets/list.cpp:248:27: warning: comparison of integer expressions of different signedness: 'int' and 'Common::Array<int>::size_type' {aka 'unsigned int'} [-Wsign-compare]
  248 |         for (int i = 0; i < _selectedItems.size(); ++i) {
      |                         ~~^~~~~~~~~~~~~~~~~~~~~~~

Changed paths:
    audio/midiparser_hmp.cpp
    gui/widgets/list.cpp


diff --git a/audio/midiparser_hmp.cpp b/audio/midiparser_hmp.cpp
index deea89ae38d..66fbe08ab98 100644
--- a/audio/midiparser_hmp.cpp
+++ b/audio/midiparser_hmp.cpp
@@ -127,7 +127,7 @@ int32 MidiParser_HMP::determineDataSize(Common::SeekableReadStream *stream) {
 	if (strcmp(stream->readString('\x00', 8).c_str(), HMP_HEADER)) {
 		return -1;
 	}
-	byte versionBytes[6];
+	byte versionBytes[6] = {0};
 	stream->readMultipleLE(*versionBytes);
 	HmpVersion version = determineVersion(versionBytes);
 	stream->skip(18);
diff --git a/gui/widgets/list.cpp b/gui/widgets/list.cpp
index 1a225025bd4..7b31f17dc64 100644
--- a/gui/widgets/list.cpp
+++ b/gui/widgets/list.cpp
@@ -225,7 +225,7 @@ void ListWidget::addSelectedItem(int item) {
 
 	// Insert in ascending order to keep selection sorted
 	bool inserted = false;
-	for (int i = 0; i < _selectedItems.size(); ++i) {
+	for (size_t i = 0; i < _selectedItems.size(); ++i) {
 		if (_selectedItems[i] > actualItem) {
 			_selectedItems.insert_at(i, actualItem);
 			inserted = true;
@@ -245,7 +245,7 @@ void ListWidget::removeSelectedItem(int item) {
 		actualItem = _listIndex[item];
 	}
 
-	for (int i = 0; i < _selectedItems.size(); ++i) {
+	for (size_t i = 0; i < _selectedItems.size(); ++i) {
 		if (_selectedItems[i] == actualItem) {
 			_selectedItems.remove_at(i);
 			break;