[Scummvm-git-logs] scummvm master -> a3cf3746e44070528badfbdbb292edd9dd4e6340
neuromancer
noreply at scummvm.org
Thu Oct 15 19:33:04 UTC 2026
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .
Summary:
a3cf3746e4 COLONY: fix artifact when rendering PToilet from one side
Commit: a3cf3746e44070528badfbdbb292edd9dd4e6340
https://github.com/scummvm/scummvm/commit/a3cf3746e44070528badfbdbb292edd9dd4e6340
Author: neuromancer (gustavo.grieco at gmail.com)
Date: 2026-10-15T21:32:44+02:00
Commit Message:
COLONY: fix artifact when rendering PToilet from one side
Changed paths:
engines/colony/render_objects.cpp
diff --git a/engines/colony/render_objects.cpp b/engines/colony/render_objects.cpp
index 8ddf4e03dcf..6794814e1a2 100644
--- a/engines/colony/render_objects.cpp
+++ b/engines/colony/render_objects.cpp
@@ -1977,17 +1977,23 @@ bool ColonyEngine::drawStaticObjectPrisms3D(Thing &obj) {
case kObjToilet:
for (int i = 0; i < 4; i++) {
_gfx->setDepthRange((3 - i) * 0.002f, 1.0f);
- draw3DPrism(obj, kToiletParts[i], false, -1, true, false);
+ // MakeToilet draws the flat raised seat from both sides.
+ draw3DPrism(obj, kToiletParts[i], false, -1, true, i == 3);
}
_gfx->setDepthRange(0.0f, 1.0f);
break;
- case kObjPToilet:
+ case kObjPToilet: {
+ // MakePToilet draws the two-sided partition first when it is behind the toilet.
+ const bool partitionBehind = isProjectedPrismSurfaceVisible(_screenR, obj, kPToiletParts[4], false, 0,
+ _me.look, _me.lookY, _me.xloc, _me.yloc, _sint, _cost);
for (int i = 0; i < 5; i++) {
+ const int part = partitionBehind ? (i == 0 ? 4 : i - 1) : i;
_gfx->setDepthRange((4 - i) * 0.002f, 1.0f);
- draw3DPrism(obj, kPToiletParts[i], false, -1, true, false);
+ draw3DPrism(obj, kPToiletParts[part], false, -1, true, part >= 3);
}
_gfx->setDepthRange(0.0f, 1.0f);
break;
+ }
case kObjForkLift:
// Draw order: forks, arms, treads, cab (back-to-front)
_gfx->setDepthRange(0.010f, 1.0f);
More information about the Scummvm-git-logs
mailing list