[ scummvm-Bugs-594920 ] Fix for #591678 broke Loom

[noreply at sourceforge.net]

Bugs item #594920, was opened at 2002-08-14 08:41
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=594920&group_id=37116

Category: Actor behavior
Group: Loom CD/Talkie
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for #591678 broke Loom

Initial Comment:
Revision 1.107 of actor.cpp (fix for #591678) broke
Loom for me. I can no longer interact with the sleeping
boy, Rusty Nailbender.

I don't know enough about this part of the code to be
able to diagnose it, but here's some data which may
possibly be helpful.This is what happens when I click
on the boy with the old, working code:

adjustXYToBeInBox(311, 90, 8)  => { 310, 81, 8 }
adjustXYToBeInBox(311, 90, -1) => { 310, 81, 8 }

And with the new, broken code:

adjustXYToBeInBox(311, 90, 8)  => { 310, 81, 8 }
adjustXYToBeInBox(311, 90, -1) => { 311, 88, 10 }

This is what the debugger has to say on the subject of
boxes:

Walk matrix:
[0] [0] [0] [1] [12] [1]
[0] [0] [0] [1] [1] [1] [2] [12] [2]
[0] [1] [1] [2] [2] [2] [3] [3] [12] [4] [11] [4] [12]
[12] [12]
[0] [2] [12] [3] [3] [3] [4] [12] [12]
[0] [3] [2] [4] [4] [4] [5] [9] [5] [10] [11] [10] [12]
[12] [2]
[0] [4] [4] [5] [5] [5] [6] [6] [6] [7] [9] [7] [10]
[11] [10] [12] [12] [4]
[0] [5] [5] [6] [6] [6] [7] [9] [7] [10] [12] [5]
[0] [5] [5] [6] [6] [6] [7] [7] [7] [8] [9] [8] [10]
[12] [5]
[0] [7] [7] [8] [8] [8] [9] [9] [9] [10] [12] [7]
[0] [8] [8] [9] [9] [9] [10] [12] [8]
[0] [4] [4] [5] [9] [5] [10] [10] [10] [11] [11] [11]
[12] [12] [4]
[0] [10] [10] [11] [11] [11] [12] [12] [10]
[0] [2] [2] [3] [3] [3] [4] [11] [2] [12] [12] [12]

Walk boxes:
0: [10 x 5] [64 x 74] [10 x 5] [64 x 74], flags=0x01,
mask=1
1: [64 x 74] [79 x 78] [64 x 74] [79 x 78], flags=0x00,
mask=1
2: [96 x 93] [153 x 93] [79 x 78] [117 x 78],
flags=0x00, mask=0
3: [72 x 106] [96 x 106] [72 x 106] [96 x 106],
flags=0xa0, mask=0
4: [153 x 93] [244 x 88] [153 x 93] [244 x 88],
flags=0x00, mask=0
5: [246 x 82] [244 x 88] [246 x 82] [244 x 88],
flags=0x00, mask=1
6: [246 x 64] [246 x 82] [246 x 64] [246 x 82],
flags=0x80, mask=1
7: [246 x 82] [298 x 82] [246 x 82] [298 x 82],
flags=0x00, mask=1
8: [298 x 82] [333 x 79] [298 x 82] [333 x 79],
flags=0x00, mask=1
9: [333 x 79] [378 x 134] [333 x 79] [378 x 134],
flags=0x01, mask=1
10: [244 x 88] [336 x 88] [244 x 88] [336 x 88],
flags=0x80, mask=0
11: [336 x 88] [384 x 88] [336 x 88] [384 x 88],
flags=0x80, mask=0
12: [96 x 93] [96 x 106] [131 x 93] [132 x 93],
flags=0x00, mask=0


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=594920&group_id=37116