[ scummvm-Bugs-1439279 ] SCUMM: SubstResFileNames partial breakage

SourceForge.net noreply at sourceforge.net
Sun Feb 26 23:25:01 CET 2006


Bugs item #1439279, was opened at 2006-02-26 23:25
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1439279&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Max Horn (fingolfin)
Assigned to: Max Horn (fingolfin)
Summary: SCUMM: SubstResFileNames partial breakage

Initial Comment:
My recent changes probably broke parts of the SubstResFileNames system 
(I can't verify this since I am missing the relevant games).

In particular, maniac1.d64/maniac2.d64 and zak1.d64/zak2.d64 likely 
aren't correctly supported at this time.

I simply missed that aspect of the SubstResFileNames system when I 
recently modified it. But I am working on a rewrite, so please bear a few 
days with me until I have the new system ready :).


But if somebody who has the relevant files (and thus can perform testing) 
wants to work on this in the meantime, I assume it could easily be fixed 
by modifying the following lines in scumm.cpp:

	} else if ((_game.platform == Common::kPlatformC64) && 
_substResFileName.winName) {
		char tmpBuf1[128], tmpBuf2[128];
		generateSubstResFileName("00.LFL", tmpBuf1, sizeof(tmpBuf1));
		generateSubstResFileName("01.LFL", tmpBuf2, sizeof(tmpBuf2));

		_fileHandle = new ScummC64File(tmpBuf1, tmpBuf2, _game.id 
== GID_MANIAC);

-> there seems to be no important reason to use 
generateSubstResFileName here, simply hardcoding the relevant *.d64 
filenames here should be just fine.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1439279&group_id=37116




More information about the Scummvm-tracker mailing list