[ scummvm-Patches-2040074 ] XMIDI callback control events

[SourceForge.net]

Patches item #2040074, was opened at 2008-08-06 13:03
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2040074&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Torbjrn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: XMIDI callback control events

Initial Comment:
This patch should be enough to implement the XMIDI callback controller event. Basically, it just adds some optional parameters to createParser_XMIDI(), so that a callback function can be specified.

However, I'm a bit torn... The main reason (for me) would be to silence the warnings in the DOS version of Simon the Sorcerer 2. This is fine, because the game doesn't actually seem to *use* the callback events. But it would also silence the warnings for games where we want the warning, because some feature is actually missing.

So maybe there should be a default callback that prints a message, and any engine that doesn't want this would have to explicitly say so?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2040074&group_id=37116