[Scummvm-tracker] [ScummVM] #10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope

[Vhati]

#10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope
--------------------------------+-------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------

Comment (by Vhati):

 @m-kiewitz
 > maybe the detection here is a false positive [...] and we can simply
 pass it through.

 > For original SCI it was fine to do a bitwise OR against a value plus an
 offset, because both were 16-bit integers

 @Vhati:
 > If SetNowSeen() were expected to return 1/0. And bitwise OR-ing that
 guarantees a 1...

 > it wasn't there to BE a condition, just something to run.

 Hm. I can't say what QFG4 is expecting from the call. Technically all the
 OR does is guarantee a non-zero result. So it could get away with
 returning a bool, an object address, or void (defacto object, with the
 call's obj param left unmodified in acc). They'd all be forced to evaluate
 as true and not abandon the if block.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10814#comment:17>
ScummVM <https://bugs.scummvm.org>
ScummVM