[Scummvm-tracker] [ScummVM :: Bugs] #11544: SCI: Incorrect palette color in Oracle scene Winged Guard portrait

[ScummVM :: Bugs]

#11544: SCI: Incorrect palette color in Oracle scene Winged Guard portrait
-----------------------------+-------------------------
  Reporter:  LinkTiger       |      Owner:  (none)
      Type:  defect          |     Status:  new
  Priority:  normal          |  Component:  Engine: SCI
Resolution:                  |   Keywords:
      Game:  King's Quest 6  |
-----------------------------+-------------------------
Comment (by sluicebox):

 I'm feeling a little less bad after calmly looking at the change and
 reviewing some old notes.

 The issue revolves around palette entry 0. ScummVM's GfxPalette::insert()
 didn't touch palette entry 0 prior to my change. This broke Hoyle4 because
 it would palette cycle when winning a hand and then the rest of the game
 would be stuck with whatever color was in palette entry 0 during the room
 transition.

 That ScummVM mistake is understandable because the common codepath in SSCI
 excludes palette entry 0, but there's a subtle different codepath, which I
 remember being complex, that would instead set all the palette entries
 including 0. That complex codepath wasn't implemented in ScummVM and so I
 added a condition that would include setting palette 0 when appropriate
 and exclude it when not.

 I'll take a deeper look at this later but I hope that's helpful in getting
 to the bottom of the discrepancy.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11544#comment:10>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM