[Scummvm-tracker] [ScummVM :: Bugs] #12021: SCI: KQ4 Rosella gets stuck entering doors

[ScummVM :: Bugs]

#12021: SCI: KQ4 Rosella gets stuck entering doors
-----------------------------+-------------------------
  Reporter:  yuv422          |      Owner:  (none)
      Type:  defect          |     Status:  new
  Priority:  high            |  Component:  Engine: SCI
Resolution:                  |   Keywords:
      Game:  King's Quest 4  |
-----------------------------+-------------------------
Comment (by sluicebox):

 The door plays a sound which triggers the room change when it completes.
 An audio problem that interferes with the sound completing would explain
 the game getting stuck as described.

 I don't have a Mac to test on right now, and the door is working for me on
 Win7, but I'm seeing problems:

 1. getItemMusic is playing in the save, which seems wrong. Its
 MusicEntry::status is kSoundPlaying. This is a short sound that plays when
 picking up an item and there are no items within reach of this save
 location. It seems like the sound played much earlier and somehow got
 never stopped. That could be a symptom of the broken audio after resuming
 from sleep on Mac.

 2. The last note of getItemMusic never stops playing when restoring the
 game, even though its MusicEntry stops. The stuck note then persists even
 after restoring an unrelated game. This didn't happen before release
 2.2.0, I bisected it to:
 https://github.com/scummvm/scummvm/commit/e16ab73cc1c4067ae24b708ff5640931dd77fbfc

 To reproduce the stuck note regression from scratch:
 1. "look under bridge" to get the golden ball
 2. Quickly save the game while getItemMusic is playing
 3. Restore the save, getItemMusic will play and the final note will be
 stuck
 4. Restore an unrelated save, the stuck note will still play

 yuv422, could you try the previous release and see if the sleep/resume
 audio problems happen? https://downloads.scummvm.org/frs/scummvm/2.1.2/

 (This save appears to be for KQ4 1.006.004 but what I'm seeing applies to
 every KQ4 version I've tested)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12021#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM