[Scummvm-tracker] [ScummVM :: Bugs] #11435: Macintosh Space Quest 1 VGA Remake: broken music

[ScummVM :: Bugs]

#11435: Macintosh Space Quest 1 VGA Remake: broken music
----------------------------+-----------------------------------
  Reporter:  vanfanel       |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  normal         |  Component:  Engine: SCI
Resolution:                 |   Keywords:  Macintosh, SCI, music
      Game:  Space Quest 1  |
----------------------------+-----------------------------------
Comment (by m-kiewitz):

 Oh and I mean writing a SCI specific MIDI parser. I would avoid touching
 the common MIDI parser that much, because it works fine for all the other
 games. SCI simply did some things quite differently.

 @ZvikaZ There should be open bug reports for these cases. In the worst
 case they were closed at some point. I can't remember specific games, but
 there were a few. I looked into certain bugs and also looked into the SCI
 16-bit MIDI parser and found out about the byte offsets.

 For example in SCI MIDI data there are byte codes for setting up a loop
 and SCI remembered that exact byte offset and when a loop got triggered,
 it went to that exact offset.

 In ScummVM this code remembers the tick and seeks to that tick. At least
 back then when I looked, the ScummVM common MIDI parser did not support
 seeking to byte offsets, only ticks.

 I think some bug reports were about incorrect instruments for example.

 It isn't possible to quickly fix it all, especially because so many games
 are involved and most work right now and putting band aids on this doesn't
 really make sense.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11435#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM